Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump slackapi/slack-github-action from 1.25.0 to 2.0.0 #16773

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PavelSBorisov
Copy link
Member

@PavelSBorisov PavelSBorisov commented Nov 25, 2024

Description:
This PR updates the slack-github-action to the newest major version https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0
Implements the new variable to allow templated payloads which were enabled by default in the previous version - https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0#only-one-payload-input-can-be-provided
Related issue(s):

Fixes #16749

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@PavelSBorisov PavelSBorisov added the github_actions Pull requests that update GitHub Actions code label Nov 25, 2024
@PavelSBorisov PavelSBorisov added this to the v0.58 milestone Nov 25, 2024
@PavelSBorisov PavelSBorisov self-assigned this Nov 25, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners November 25, 2024 14:53
@PavelSBorisov PavelSBorisov linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link

codacy-production bot commented Nov 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f8e912a) 97511 63616 65.24%
Head commit (f4945c9) 97511 (+0) 63616 (+0) 65.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16773) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.53%. Comparing base (f8e912a) to head (f4945c9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16773   +/-   ##
==========================================
  Coverage      63.53%   63.53%           
  Complexity     20370    20370           
==========================================
  Files           2537     2537           
  Lines          94746    94746           
  Branches        9902     9902           
==========================================
  Hits           60198    60198           
  Misses         30941    30941           
  Partials        3607     3607           

Impacted file tree graph

@PavelSBorisov PavelSBorisov force-pushed the 16749-update-workflow-to-function-with-major-slack-version-roll branch from a31f710 to 4c00fc2 Compare November 26, 2024 07:36
@rbarkerSL
Copy link
Contributor

I ran a test against this branch on prepare-xts-candidate: https://github.com/hashgraph/hedera-services/actions/runs/12035146720

It failed because the incoming webhook isn't set correctly. I believe that it wants SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK to be SLACK_WEBHOOK_TYPE: 'incoming-webhook'

Comment on lines 892 to 897
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.slack-webhook-url }}
with:
payload-templated: true
payload: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.slack-webhook-url }}
with:
payload-templated: true
payload: |
with:
payload-templated: true
webhook: ${{ secrets.slack-webhook-url }}
webhook-type: incoming-webhook
payload: |

Comment on lines 144 to +148
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_RELEASE_WEBHOOK }}
with:
payload-templated: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_RELEASE_WEBHOOK }}
with:
payload-templated: true
with:
payload-templated: true
webhook: ${{ secrets.SLACK_RELEASE_WEBHOOK }}
webhook-type: incoming-webhook

Comment on lines 289 to +293
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
with:
payload-templated: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
with:
payload-templated: true
with:
payload-templated: true
webhook: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
webhook-type: incoming-webhook

Comment on lines 235 to +239
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
with:
payload-templated: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
with:
payload-templated: true
with:
payload-templated: true
webhook: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
webhook-type: incoming-webhook

Comment on lines 132 to +136
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
with:
payload-templated: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
with:
payload-templated: true
with:
payload-templated: true
webhook: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }}
webhook-type: incoming-webhook

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a newly added section: report-promotion: which will need the same updates as well. It's at line 152

      - name: Report Promoted Build
        uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
        env:
          SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_OPERATIONS_WEBHOOK }}
        with:
          payload: |

becomes

      - name: Report Promoted Build
        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
        with:
          payload-templated: true
          webhook: ${{ secrets.SLACK_CITR_OPERATIONS_WEBHOOK }}
          webhook-type: incoming-webhook
          payload: |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update workflow to function with major slack version roll
2 participants