-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump slackapi/slack-github-action from 1.25.0 to 2.0.0 #16773
base: develop
Are you sure you want to change the base?
build(deps): bump slackapi/slack-github-action from 1.25.0 to 2.0.0 #16773
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16773 +/- ##
==========================================
Coverage 63.53% 63.53%
Complexity 20370 20370
==========================================
Files 2537 2537
Lines 94746 94746
Branches 9902 9902
==========================================
Hits 60198 60198
Misses 30941 30941
Partials 3607 3607 |
Signed-off-by: PavelSBorisov <[email protected]>
a31f710
to
4c00fc2
Compare
I ran a test against this branch on prepare-xts-candidate: https://github.com/hashgraph/hedera-services/actions/runs/12035146720 It failed because the incoming webhook isn't set correctly. I believe that it wants |
…jor-slack-version-roll
env: | ||
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | ||
SLACK_WEBHOOK_URL: ${{ secrets.slack-webhook-url }} | ||
with: | ||
payload-templated: true | ||
payload: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | |
SLACK_WEBHOOK_URL: ${{ secrets.slack-webhook-url }} | |
with: | |
payload-templated: true | |
payload: | | |
with: | |
payload-templated: true | |
webhook: ${{ secrets.slack-webhook-url }} | |
webhook-type: incoming-webhook | |
payload: | |
env: | ||
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_RELEASE_WEBHOOK }} | ||
with: | ||
payload-templated: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | |
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_RELEASE_WEBHOOK }} | |
with: | |
payload-templated: true | |
with: | |
payload-templated: true | |
webhook: ${{ secrets.SLACK_RELEASE_WEBHOOK }} | |
webhook-type: incoming-webhook |
env: | ||
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | ||
with: | ||
payload-templated: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | |
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | |
with: | |
payload-templated: true | |
with: | |
payload-templated: true | |
webhook: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | |
webhook-type: incoming-webhook |
env: | ||
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | ||
with: | ||
payload-templated: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | |
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | |
with: | |
payload-templated: true | |
with: | |
payload-templated: true | |
webhook: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | |
webhook-type: incoming-webhook |
env: | ||
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | ||
with: | ||
payload-templated: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | |
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | |
with: | |
payload-templated: true | |
with: | |
payload-templated: true | |
webhook: ${{ secrets.SLACK_CITR_FAILURES_WEBHOOK }} | |
webhook-type: incoming-webhook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has a newly added section: report-promotion:
which will need the same updates as well. It's at line 152
- name: Report Promoted Build
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
env:
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CITR_OPERATIONS_WEBHOOK }}
with:
payload: |
becomes
- name: Report Promoted Build
uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
with:
payload-templated: true
webhook: ${{ secrets.SLACK_CITR_OPERATIONS_WEBHOOK }}
webhook-type: incoming-webhook
payload: |
Description:
This PR updates the slack-github-action to the newest major version https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0
Implements the new variable to allow templated payloads which were enabled by default in the previous version - https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0#only-one-payload-input-can-be-provided
Related issue(s):
Fixes #16749
Notes for reviewer:
N/A
Checklist