Apply suggestions from code review - Nathan's Input

Signed-off-by: Andrew Brandt <[email protected]>
hashgraph · Oct 22, 2024 · e2a981d · e2a981d
1 parent 3a70aef
commit e2a981d
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 10 deletions.
diff --git a/.github/workflows/flow-node-performance-tests.yaml b/.github/workflows/flow-node-performance-tests.yaml
@@ -77,7 +77,6 @@ jobs:
 
       - name: Check If Release Artifact Exist in Bucket
         id: check-if-exist
-        if: ${{ !github.event.workflow_dispatch.repository.fork }}
         run: |
           set +e
           ARTIFACT_NAME="build-${{ steps.parameters.outputs.branch-name-lower }}-${{ steps.parameters.outputs.commit-id-short }}"
@@ -100,7 +99,6 @@ jobs:
 
       - name: Reset Network
         id: reset-network
-        if: ${{ !github.event.workflow_dispatch.repository.fork }}
         run: |
           curl -X POST 'https://ci.preprod.hedera-devops.com/generic-webhook-trigger/invoke?token=${{ secrets.JENKINS_NETWORK_RESET }}&command=/devops-reset&text=engnet1%20${{ steps.check-if-exist.outputs.build-version }}&user_id=${{ vars.SLACK_ID }}&user_name=${{ vars.SLACK_USER }}&channel_id=${{ vars.DEVOP_CHANNEL_ID }}&channel_name=${{ vars.DEVOP_CHANNEL_NAME }}'
           echo "Sleep 6 minutes for network reset"
@@ -117,7 +115,6 @@ jobs:
 
       - name: Restore Old Signed State
         id: restore-old-signed-state
-        if: ${{ !github.event.workflow_dispatch.repository.fork }}
         run: |
           curl -X POST 'https://ci.preprod.hedera-devops.com/generic-webhook-trigger/invoke?token=${{ secrets.JENKINS_RESTORE_BACKUP }}&command=/devops-restore-backup&text=gs%3A%2F%2Fchillybin%2Fengnet1-state%2Fengnet1-node00%2F${{ vars.GS_STATE }}&user_id=${{ vars.SLACK_ID }}&user_name=${{ vars.SLACK_USER }}&channel_id=${{ vars.DEVOP_CHANNEL_ID }}&channel_name=${{ vars.DEVOP_CHANNEL_NAME }}'
           echo "Sleep 18 minutes for network to load"

diff --git a/.github/workflows/node-flow-build-application.yaml b/.github/workflows/node-flow-build-application.yaml
@@ -61,7 +61,6 @@ defaults:
 jobs:
   code:
     name: Code
-    if: ${{ !github.event.workflow_dispatch.repository.fork }}
     uses: ./.github/workflows/node-zxc-compile-application-code.yaml
     with:
       java-version: ${{ github.event.inputs.java-version || '21' }}

diff --git a/.github/workflows/node-flow-deploy-adhoc-artifact.yaml b/.github/workflows/node-flow-deploy-adhoc-artifact.yaml
@@ -46,8 +46,6 @@ defaults:
 jobs:
   release-adhoc:
     name: Release [Adhoc]
-    if: ${{ github.event_name == 'workflow_dispatch' &&
-            !github.event.workflow_dispatch.repository.fork }}
     uses: ./.github/workflows/node-zxc-build-release-artifact.yaml
     with:
       version-policy: branch-commit

diff --git a/.github/workflows/node-flow-deploy-preview.yaml b/.github/workflows/node-flow-deploy-preview.yaml
@@ -73,7 +73,6 @@ jobs:
 
   deploy-tag:
     name: Deploy Tag
-    if: ${{ !github.event.workflow_dispatch.repository.fork }}
     uses: ./.github/workflows/node-zxc-deploy-preview.yaml
     needs:
       - prepare-deploy-preview

diff --git a/.github/workflows/node-flow-deploy-release-artifact.yaml b/.github/workflows/node-flow-deploy-release-artifact.yaml
@@ -74,7 +74,6 @@ jobs:
 
   release-tag:
     name: Release [Tag]
-    if: ${{ !github.event.workflow_run.head_repository.fork }}
     uses: ./.github/workflows/node-zxc-build-release-artifact.yaml
     needs:
       - prepare-tag-release
@@ -103,7 +102,6 @@ jobs:
 
   release-branch:
     name: Release [Branch]
-    if: ${{ !github.event.workflow_run.head_repository.fork }}
     uses: ./.github/workflows/node-zxc-build-release-artifact.yaml
     if: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success'}}
     with:

diff --git a/.github/workflows/node-flow-fsts-custom-regression.yaml b/.github/workflows/node-flow-fsts-custom-regression.yaml
@@ -59,7 +59,6 @@ concurrency:
 jobs:
   jrs-panel:
     name: JRS Panel
-    if: ${{ !github.event.workflow_dispatch.repository.fork }}
     uses: ./.github/workflows/zxc-jrs-regression.yaml
     with:
       hedera-tests-enabled: true