Use approximation to idenfify ints in log_format

has2k1 · Sep 28, 2022 · ccb2f86 · ccb2f86
1 parent 3458383
commit ccb2f86
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/mizani/formatters.py b/mizani/formatters.py
@@ -494,8 +494,9 @@ def __call__(self, x):
         else:
             def _exp(num, base):
                 e = np.log(num)/np.log(base)
-                if float.is_integer(e):
-                    e = int(e)
+                e_round = np.round(e)
+                if np.isclose(e, e_round):
+                    e = int(e_round)
                 else:
                     e = np.round(e, 3)
                 return e

diff --git a/mizani/tests/test_formatters.py b/mizani/tests/test_formatters.py
@@ -106,6 +106,9 @@ def test_log_format():
     formatter = log_format(base=8)
     assert formatter([1, 4, 8, 64]) == ['8^0', '8^0.667', '8^1', '8^2']
 
+    formatter = log_format(base=5)
+    assert formatter([1, 5, 25, 125]) == ['5^0', '5^1', '5^2', '5^3']
+
     formatter = log_format(base=np.e)
     assert formatter([1, np.pi, np.e**2, np.e**3]) == \
         ['e^0', 'e^1.145', 'e^2', 'e^3']