Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github actions docker secrets #98

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix github actions docker secrets #98

merged 1 commit into from
Jun 5, 2024

Conversation

brandboat
Copy link
Member

as title, now the Build and push images job failed due to incorrect secrets.

FrankYang0529
FrankYang0529 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@FrankYang0529 FrankYang0529 requested a review from bk201 June 5, 2024 01:37
bk201
bk201 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bk201 bk201 merged commit d2f4cf3 into harvester:master Jun 5, 2024
2 checks passed
@brandboat brandboat deleted the minor-fix-actions branch June 5, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

@bk201 bk201 bk201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandboat @bk201 @FrankYang0529