Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make sure the if-condition works (backport #143) #146

Open
wants to merge 1 commit into
base: v0.6.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 27, 2024

Problem:
The CI teardown flow is not working.

Need always() to trigger the steps, or steps after the failure cannot be executed.

Solution:
Make sure the if-condition works

Related Issue:

Test plan:


This is an automatic backport of pull request #143 done by [Mergify](https://mergify.com).

Signed-off-by: Vicente Cheng <[email protected]>
(cherry picked from commit 78e0d91)

# Conflicts:
#	.github/workflows/basic-ci.yaml
@mergify mergify bot added the conflicts label Sep 27, 2024
Copy link
Author

mergify bot commented Sep 27, 2024

Cherry-pick of 78e0d91 has failed:

On branch mergify/bp/v0.6.x/pr-143
Your branch is up to date with 'origin/v0.6.x'.

You are currently cherry-picking commit 78e0d91.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/basic-ci.yaml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant