Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDTM to allow for filenames where lead time is in minutes #115

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

j-fannon
Copy link

Presumably something better should be done, or has already been done?

@j-fannon j-fannon marked this pull request as draft December 17, 2024 12:05
@andrew-MET
Copy link
Collaborator

Yes - the idea is that user will specify the units in the lead_time argument. If numeric, it'll be assumed to be in hours so as not to break the current behaviour, otherwise a unit could be added using "s", "m", "h", "d", probably using one of the seq_secs(), seq_mins(), seq_hours() or seq_days() functions that already exist. The lead time units in the filename will be assumed to be the same as those passed to lead_time.

This ultimately means that lead times will be stored in seconds rather than hours as they currently are, so there's quite a bit of code that will need changing to accommodate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants