Upgrade bouncycastle dependencies to 1.72

[wborn]

Fixes #80
Succeeds #146

For release notes, see:

https://www.bouncycastle.org/releasenotes.html#r1rv72

Pull Request Checklist

Please confirm that you've done the following when opening a new pull request:

• For fixes and other improvements, please reference the GitHub issue that your change addresses.
• For fixes, optimizations and new features, please add an entry to the CHANGES.md file.
• Run mvn compile before committing, so that the auto-code formatter will format your changes consistently with the rest of the project.

[wborn]

As Java 8 is targeted:

HAP-Java/pom.xml

Lines 184 to 185 in 781311e

	<source>1.8</source>
	<target>1.8</target>

the "jdk18on" artifacts can be used. 🙂

[ccutrer]

If I apply this, then the HomeKit add-on won't load in OpenHAB 3.4.0-SNAPSHOT (as of last night), citing Unresolved requirement: Import-Package: org.bouncycastle.tls; version="[1.72.0,2.0.0)". Is there a migration plan, or do all addons have to update to the new artifactid at the same time?

[wborn]

Thanks for having a look! Did you also build an add-on with the changes in openhab/openhab-addons#11104? Those changes are required for embedding bouncycastle 1.72 into the bundle.

[ccutrer]

I didn't see that PR. I now tried it. I can install the bundle, but logging reports 2022-10-14 13:57:55.948 [WARN ] [.server.impl.connections.HttpSession] - Unrecognized request for /characteristics (which means it's using the unauthenticated servlet, instead of the authenticated one), and every accessory shows up as "No Response" on iOS.

[wborn]

That's unfortunate since I don't use HomeKit myself so I can't easily test or debug it. 🙁

Do you have an idea what goes wrong? Is there some kind of HomeKit client that can be used for testing?

It would be helpful if there were unit tests for testing the crypto logic which would then fail with the upgraded dependencies. Then I could look into fixing those test. 🙂