Fix typo in nss_keylog_export #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `CLIENT RANDOM` -> `CLIENT_RANDOM`. This appears a typo as it is [CLIENT_RANDOM](https://github.com/ARMmbed/mbedtls/blob/development/programs/ssl/ssl_test_common_source.c#L72) in upstream and in the [document](https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Key_Log_Format). Test Plan: `tests/ssl-opt.sh` Reviewers: Subscribers: Tasks: Tags:
|
The change suggested refers to the exporter used with TLS 1.2. However, the label used "CLIENT RANDOM" is not one of the registered labels, see https://datatracker.ietf.org/doc/html/rfc5705 and https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#exporter-labels. Since even the two key derivation functions are different, I wonder whether a separate code path for 1.2 is required and whether this entry should be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CLIENT RANDOM->CLIENT_RANDOM. This appears a typo as it is CLIENT_RANDOM in upstream and in the document.Test Plan:
tests/ssl-opt.shReviewers:
Subscribers:
Tasks:
Tags:
Notes:
Signed-off-by:line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.Description
A few sentences describing the overall goals of the pull request's commits.
Status
READY/IN DEVELOPMENT/HOLD
Requires Backporting
When there is a bug fix, it should be backported to all maintained and supported branches.
Changes do not have to be backported if:
Yes | NO
Which branch?
Migrations
If there is any API change, what's the incentive and logic for it.
YES | NO
Additional comments
Any additional information that could be of interest
Todos
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.