Add options test script #303
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
requested changes
Jul 22, 2021
There was a problem hiding this comment.
Apologies @yuhaoth, but this doesn't match the way configuration testing normally works in Mbed TLS. Tests for specific configurations should be added to all.sh as test components. Those test components may modify the default config through application of the script config.py and then build and run Mbed TLS in the particular configuration.
Please take a look and let me know if anything is unclear.
|
Before all.sh done, keep this one. |
yuhaoth
force-pushed
the
pr/add-options-test-script
branch
from
d12d784
to
f51b47c
Compare
According to hannestschofenig#15, different options report fail. To fix the issue we should not break passed options. The script is to make sure current status. If all relative issues are resolved, This patch should be removed or re-considered. issues: hannestschofenig#15, hannestschofenig#297,hannestschofenig#238,hannestschofenig#298,hannestschofenig#301 Change-Id: Iaebbdaa5861802f2a48e6bca238a94672ddfaf70 CustomizedGitHooks: yes Signed-off-by: Jerry Yu <[email protected]>
yuhaoth
force-pushed
the
pr/add-options-test-script
branch
from
f51b47c
to
d855fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and test with different options report error .
This script is to test the status with/without MPS ,Non block io , TLS1_2 and TLS1_3.
Now, 9 cases fail . That is list in #301.
It should be considered merged as a common script or left here. I need suggestion