Compile when few options are set #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stack is compiled with minimal extensions (without 0RTT, ALPN, MFL, and MPS) then compilation errors occur
|
I'm hitting a new error: |
zhihan
reviewed
Jul 16, 2021
zhihan
reviewed
Jul 16, 2021
library/ssl_tls13_client.c
Outdated
| @@ -176,10 +176,13 @@ int ssl_write_early_data_process( mbedtls_ssl_context* ssl ) | |||
| #endif /* MBEDTLS_SSL_USE_MPS */ | |||
|
|
|||
| #else /* MBEDTLS_ZERO_RTT */ | |||
| #if defined(MBEDTLS_SSL_USE_MPS) | |||
There was a problem hiding this comment.
ISTM that we should rather guard the declarations of buf, buf_len, ... by MBEDTLS_SSL_USE_MPS && MBEDTLS_ZERO_RTT.
library/ssl_tls13_client.c
Outdated
| @@ -2725,6 +2728,9 @@ static int ssl_encrypted_extensions_parse( mbedtls_ssl_context* ssl, | |||
| size_t ext_len; | |||
| const unsigned char *ext; | |||
|
|
|||
| /* ssl structure is not used when ALPN, 0RTT, and MFL extensions are not used. */ | |||
There was a problem hiding this comment.
The comment should be replaced by the appropriate compile-time guard.
library/ssl_tls13_server.c
Outdated
| @@ -2269,6 +2269,10 @@ static int ssl_client_hello_fetch( mbedtls_ssl_context* ssl, | |||
|
|
|||
| static void ssl_debug_print_client_hello_exts( mbedtls_ssl_context *ssl ) | |||
| { | |||
| #if !defined(MBEDTLS_DEBUG_C) | |||
There was a problem hiding this comment.
ISTM that the entire function could be guarded by MBEDTLS_DEBUG_C and defined as a dummy if !MBEDTLS_DEBUG_C.
hanno-becker
requested changes
Jul 22, 2021
hanno-becker
reviewed
Aug 5, 2021
hanno-becker
reviewed
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the stack is compiled with minimal extensions (without 0RTT, ALPN, MFL, and MPS) then compilation errors occur due to unused variables.
Status
DONE
Requires Backporting
NO
Migrations
NO
Additional comments
Todos
Steps to test or reproduce
To reproduce the errors, use the config.h file from the EEMBC benchmark here:
https://raw.githubusercontent.com/eembc/mbedtls/eembc-setup/include/mbedtls/config.h