Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session minor ver #274

Closed
wants to merge 4 commits into from
Closed

Fix session minor ver #274

wants to merge 4 commits into from

Conversation

zhihan
Copy link

@zhihan zhihan commented May 27, 2021

This should fix #273

It looks the current implementation hard-coded the minor version when loading the ssl session. I think it should read the minor version field from the saved data. But I would defer that to a later PR. This small change makes it consistent with the prototype code (the statement above the change).

@zhihan zhihan closed this May 27, 2021
@zhihan zhihan deleted the fix-session-minor_ver branch June 1, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session->minor_ver is never populated
1 participant