MFL API Fix #243
Merged
MFL API Fix #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
reviewed
May 2, 2021
Co-authored-by: Hanno Becker <[email protected]>
hanno-becker
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #209
The goal was also to better align the API (as noted here #130). However, the upstream Mbed TLS code has no harmonized API signature for the extension handling between the client and the server code either. Hence, the currently used API signature is consistent with the approach selected for upstream Mbed TLS in the sense that it is equally inconsistent.
In a future attempt to reduce the code size the extension handling code should be moved out of the client and server files. This would offer the possibility to do some harmonization.