-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the version of the action steps #27
Conversation
长久来看,可以提供一个公开的workflows仓库,将插件的构建流程写到workflows仓库中,starter模板引用workflows仓库的流水线内容,需要自定义的部分以参数的形式提供,以下是相关文档: 实践内容可参考: https://github.com/Mystery0Tools/workflows/tree/main/.github/workflows |
不错的建议,是有这个计划的,可以 follow:halo-sigs/actions#10 但暂时还没时间弄。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢 @Mystery00 的贡献。
/lgtm
/retitle Upgrade the version of the action steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Mystery00 @guqing
|
Hi @sczhaoqi , 感谢提醒,我们已经提供了新的 workflows 配置可以引用,已经考虑到了这个问题,稍后我会提交一个 PR 来替换 workflow 的配置 , 可以查看 #28 |
根据Github的相关文档说明,在后期会弃用set-output的方式设置Action的返回值,因此按照文档的方式对设置返回值的逻辑进行修改,同时更新目前使用到的Actions的版本,规避set-output的问题同时修复低版本Actions中可能存在的漏洞
Github文档: GitHub Actions: Deprecating save-state and set-output commands