Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

添加关于自定义工作目录的提示 (#474) #484

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

添加关于自定义工作目录的提示 (#474) #484

wants to merge 4 commits into from

Conversation

lingrottin
Copy link

#474

看样子在下面编写 systemd 单元文件的地方也需要提示一下，但是具体形式还需斟酌

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 10, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby December 10, 2024 15:54
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 10, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ruibaby for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 3:31pm

@ruibaby
Copy link
Member

ruibaby commented Dec 17, 2024

感谢贡献，需要同时修改一下：https://github.com/halo-dev/docs/blob/main/versioned_docs/version-2.20/getting-started/install/jar-file.md

lingrottin
lingrottin commented Dec 25, 2024
View reviewed changes
versioned_docs/version-2.20/getting-started/install/jar-file.md
@@ -212,7 +216,7 @@ title: 使用 JAR 文件部署
- **USER**：运行 Halo 的系统用户，如果有按照上方教程创建新的用户来运行 Halo，修改为你创建的用户名称即可。反之请删除 `User=USER`。

:::tip
请确保 `/usr/bin/java` 是正确无误的。建议将 `ExecStart` 中的命令复制出来运行一下，保证命令有效。
请确保 `/usr/bin/java` 是正确无误的。建议将 `ExecStart` 中的命令复制出来运行一下，保证命令有效。如果指定了其他工作目录，请像上面一样改动。
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不太确定合不合适 😣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing Awaiting requested review from guqing

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lingrottin @ruibaby