Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add halo on podman #256

Merged
merged 9 commits into from
Sep 27, 2023
Merged

docs: add halo on podman #256

merged 9 commits into from
Sep 27, 2023

Conversation

wangxiaoerYah
Copy link
Contributor

添加使用 Podman 部署Halo的方法.

None

@vercel
Copy link

vercel bot commented Sep 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 5:13am

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 14, 2023
@wangxiaoerYah
Copy link
Contributor Author

第一次为halo做贡献，有什么不对的地方，请指出。

@guqing
Copy link
Member

guqing commented Sep 15, 2023

/cc @halo-dev/sig-docs

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 15, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-docs.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-dev/sig-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby
Copy link
Member

ruibaby commented Sep 24, 2023

Hi @wangxiaoerYah ，抱歉这个 PR 没有及时 Review，我们最近在忙 2.10.x 的功能，所以没有太多时间进行验证。我将重新打开，有时间之后会验证并合并。

/reopen

@f2c-ci-robot f2c-ci-robot bot reopened this Sep 24, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 24, 2023

@ruibaby: Reopened this PR.

In response to this:

Hi @wangxiaoerYah ，抱歉这个 PR 没有及时 Review，我们最近在忙 2.10.x 的功能，所以没有太多时间进行验证。我将重新打开，有时间之后会验证并合并。

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangxiaoerYah
Copy link
Contributor Author

更新了podman文档中部分错误.

ruibaby
ruibaby requested changes Sep 25, 2023
View reviewed changes
docs/getting-started/install/podman.md Show resolved Hide resolved
docs/getting-started/install/podman.md Outdated Show resolved Hide resolved
docs/getting-started/install/podman.md Outdated Show resolved Hide resolved
versioned_docs/version-2.9/getting-started/install/podman.md Outdated Show resolved Hide resolved
versioned_docs/version-2.9/getting-started/install/podman.md Outdated Show resolved Hide resolved
@wangxiaoerYah
Copy link
Contributor Author

按照要求更新了文档.

@JohnNiang
Copy link
Member

/ping @halo-dev/sig-docs

JohnNiang
JohnNiang reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wangxiaoerYah ，可能还需要修改 https://github.com/halo-dev/docs/blob/main/sidebars.js 以保证在最新版的菜单中能显示对应的文档。

@wangxiaoerYah
Copy link
Contributor Author

Hi @wangxiaoerYah ，可能还需要修改 https://github.com/halo-dev/docs/blob/main/sidebars.js 以保证在最新版的菜单中能显示对应的文档。

已修改,之前没有了解过docusaurus,所以修改有些繁琐了点.抱歉.

@JohnNiang JohnNiang requested a review from ruibaby September 27, 2023 04:32
JohnNiang
JohnNiang reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@ruibaby
Copy link
Member

ruibaby commented Sep 27, 2023

@wangxiaoerYah 建议全局替换一下 https://xxx.com，使用 https://localhost:8090，虽然是示例域名，但 xxx.com 似乎是一个可访问（且不健康）的网站。

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@wangxiaoerYah
Copy link
Contributor Author

抱歉,我看走眼了🤣🤣.我怎么没想到这居然是个正常网站.

@wangxiaoerYah
Copy link
Contributor Author

@wangxiaoerYah 建议全局替换一下 https://xxx.com，使用 https://localhost:8090，虽然是示例域名，但 xxx.com 似乎是一个可访问（且不健康）的网站。

已更改.

@JohnNiang
Copy link
Member

Hi @wangxiaoerYah and @ruibaby ，其实我更建议不在这里配置 external-url。后续更建议在配置文件中配置即可。这样用户在修改配置后只需要重启容器即可，而不是重建运行命令。

@wangxiaoerYah
Copy link
Contributor Author

Hi @wangxiaoerYah and @ruibaby ，其实我更建议不在这里配置 external-url。后续更建议在配置文件中配置即可。这样用户在修改配置后只需要重启容器即可，而不是重建运行命令。

噢噢,看来我的理解有误了,我一直都将ext url放在里面.我以为这是正确的运行方式.😂😂😂

@JohnNiang
Copy link
Member

Hi @wangxiaoerYah and @ruibaby ，其实我更建议不在这里配置 external-url。后续更建议在配置文件中配置即可。这样用户在修改配置后只需要重启容器即可，而不是重建运行命令。

噢噢,看来我的理解有误了,我一直都将ext url放在里面.我以为这是正确的运行方式.😂😂😂

参数配置形式一般作为快速开始或者分享复现步骤的时候比较有用，生产环境还是建议用 ~/.halo2/application.yaml 的方式进行配置。

@wangxiaoerYah
Copy link
Contributor Author

Hi @wangxiaoerYah and @ruibaby ，其实我更建议不在这里配置 external-url。后续更建议在配置文件中配置即可。这样用户在修改配置后只需要重启容器即可，而不是重建运行命令。

其实我觉得应该直接写到数据库里,在第一次搭建时,最好有个类似于worldpress那种引导界面,让用户通过图形化配置.
然后如果迁移到新网址,怎么办呢,就是访问console管理界面时就不要验证是不是用户配置的域,等到用户登录了管理界面,前端或者后端再去检测当前域,提示用户要不要修改.
Cloudreve那个项目它对迁移域就是这样做的.

但是正常访问时要严格验证域,防止盗链,只在管理界面不做验证.

这样还可以在nginx层将console管理界面强制定向到另一个网址.防止被恶意爆破.

ruibaby
ruibaby approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 587cd95 into halo-dev:main Sep 27, 2023
@ruibaby
Copy link
Member

ruibaby commented Sep 27, 2023 •
edited
Loading

其实我觉得应该直接写到数据库里,在第一次搭建时,最好有个类似于worldpress那种引导界面,让用户通过图形化配置.
然后如果迁移到新网址,怎么办呢,就是访问console管理界面时就不要验证是不是用户配置的域,等到用户登录了管理界面,前端或者后端再去检测当前域,提示用户要不要修改.

后续可以考虑在 Console 配置外部访问链接，目前 external-url 的意义更多的是一个主域名（比如生成 sitemap 会需要域名来确定链接，邮件模板也需要这个域名来生成绝对地址），即便配置不正确也不会影响系统的访问。如果后续需要换域名，目前也只需要修改这个 external-url 参数并重建容器。

@ruibaby
Copy link
Member

ruibaby commented Sep 27, 2023 •
edited
Loading

参数配置形式一般作为快速开始或者分享复现步骤的时候比较有用，生产环境还是建议用 ~/.halo2/application.yaml 的方式进行配置。

如果要改，建议在未来某个合适的时候一起修改。目前建议文档为主，是怎么样就是怎么样，给用户太多的配置选择反而会造成困扰，尤其是最终达到的效果都是一致的。

@JohnNiang
Copy link
Member

Hi @wangxiaoerYah ，现在之所以需要在配置文件中配置 external-url，主要是因为修改它后，文章、页面、分类、标签和菜单等的访问链接需要同步修改。这些操作重启 Halo 后才能生效。

@wangxiaoerYah
Copy link
Contributor Author

Hi @wangxiaoerYah ，现在之所以需要在配置文件中配置 external-url，主要是因为修改它后，文章、页面、分类、标签和菜单等的访问链接需要同步修改。这些操作重启 Halo 后才能生效。

噢噢,明白了.

@ruibaby
Copy link
Member

ruibaby commented Sep 27, 2023

感谢 @wangxiaoerYah 参与贡献🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@ruibaby ruibaby ruibaby approved these changes

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangxiaoerYah @guqing @ruibaby @JohnNiang