Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Old Pull Event, Pull Orgs commands, and related files #199

Merged

Conversation

bogdankharchenko
Copy link
Collaborator

We no longer need these commands and the associated data files.

@allella
Copy link
Member

allella commented Jan 12, 2024

Closes #200, which has some additional questions about naming consistency and adding descriptions to the task and such.

@allella allella linked an issue Jan 12, 2024 that may be closed by this pull request
@allella
Copy link
Member

allella commented Jan 12, 2024

Do we have and alternative to the app/Console/Commands/TruncateOrgsAndEvents.php that's been deleted?

I think we used that one after the upgrade, but in the past we've had to use similar commands to purge things to fix bugs.

@bogdankharchenko
Copy link
Collaborator Author

Do we have and alternative to the app/Console/Commands/TruncateOrgsAndEvents.php that's been deleted?

I think we used that one after the upgrade, but in the past we've had to use similar commands to purge things to fix bugs.

I don't think we will need to do any purging moving forward

@allella
Copy link
Member

allella commented Jan 16, 2024

@bogdankharchenko looks like a merge conflict on this PR, so I can't merge it.

Also, #200 had a couple other questions that I figured could be addressed in this PR.

  • The import:events doesn't have a description when you run php artisan and it would help. It would be helpful to add a description since it seems to do more that import events.
  • Or, should we consider naming this task import:orgs-and-events since it imports more than just events?
  • Do we need the import: prefix or would we prefer to have app:import-orgs-and-events

Thanks

@bogdankharchenko
Copy link
Collaborator Author

@bogdankharchenko looks like a merge conflict on this PR, so I can't merge it.

Also, #200 had a couple other questions that I figured could be addressed in this PR.

  • The import:events doesn't have a description when you run php artisan and it would help. It would be helpful to add a description since it seems to do more that import events.
  • Or, should we consider naming this task import:orgs-and-events since it imports more than just events?
  • Do we need the import: prefix or would we prefer to have app:import-orgs-and-events

Thanks

  1. I will add a description and resolve conflicts.
  2. We no longer will import Organizations - since they now live this project/database.
  3. I'm personally a fan of easy commands: import:events seems like a good choice for me, but I'm not married to it.

Let me know if you have any other questions

@allella allella merged commit a41daa8 into hackgvl:develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Old Artisan pull Tasks and Clean up Task Names and Descriptions
2 participants