Set TZ in transformer to America/New_York from EDT

[ThorntonMatthewD]

Summary

Switches the timezone used for casting event times in EventDataTransformer from using a type 2 "EDT" timezone to a type 3 "America/New_York" timezone that will automatically account for daylight savings time.

Testing Plan

1. Before checking out this branch run php artisan pull:events
2. Launch the application and navigate to /events
3. The times, since we've fallen back from EDT to EST, will appear an hour later than they're actually scheduled for. Compare with the OpenWorks events dashboard.
4. Also be sure to stop by the /calendar page to see that the same issue exists there.
5. Checkout the branch for this PR and re-run php artisan pull:events
6. Refresh the /events and /calendar pages. The times should now appear correctly.

[allella]

Thanks for working on this @ThorntonMatthewD

We do have the TZ .env variable that I think becomes the config/app.php as the 'timezone'.

I suspect we shouldn't hard code the timezone. Or, we could pull from the config, and use the New York as the default value if the config isn't set?

https://laravel.com/docs/10.x/configuration#accessing-configuration-values

[allella]

I ran Matt's PR as a patch on stage and it fixed the issue, so I ran it on the live site too.

I guess there's a chance we have a problem again when daylight savings reverts, but the hardcoded EDT in the app/Data/EventDataTransformer.php seems like a fair chance of being the issue.

I think we should pull the America/New_York from the Laravel config, instead of hard coding it. So, that's the main thing I think we should change on this PR.

Thanks Matt.

[allella]

@ThorntonMatthewD were you trying to do anything more on this PR, or is it ready to go?

[ThorntonMatthewD]

@allella The couple of unit tests were all I was after since yesterday. Since those are up I think this iteration of the TZ fix is ready for review.

[ThorntonMatthewD]

^ I actually forgot to change back one last thing. NOW things are good. 😄