Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Project Profile: Add Srishti Gupta to Expunge Assist Page #7757

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Update Project Profile: Add Srishti Gupta to Expunge Assist Page #7757

merged 2 commits into from
Nov 27, 2024

Conversation

katiejnete
Copy link
Member

@katiejnete katiejnete commented Nov 22, 2024 •
edited
Loading

Fixes #7703

What changes did you make?

  • Added project profile Srishti Gupta lines to the leadership variable in expunge-assist markdown file _projects/expunge-assist.md

Why did you make the changes (we will use this info to test)?

  • To keep list of current project team members under Expunge Assist up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b katiejnete-update-expunge-assist-srishti-gupta-7703 gh-pages
git pull https://github.com/katiejnete/website.git update-expunge-assist-srishti-gupta-7703

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 22, 2024
@mugdhchauhan mugdhchauhan self-requested a review November 22, 2024 14:49
@mugdhchauhan
Copy link
Member

Review ETA: 22 Nov 2024 @ 8 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

@trimakichan trimakichan self-requested a review November 22, 2024 16:47
@trimakichan
Copy link
Member

Review ETA: Nov 22nd, 6 PM
Availability: 10 AM to 3 PM (M-F, PST)

mugdhchauhan
mugdhchauhan requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mugdhchauhan mugdhchauhan left a comment •
edited by katiejnete
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @katiejnete, thank you for your Pull Request!

Things that went well

  • The Pull Request is done with the correct branch.
  • The issue is linked well in the Pull Request.
  • What changes you made and why are clear in the PR post.
  • Your Availability and ETA are provided in the issue.
  • The information for Srishti Gupta is added in the correct file as provided in the issue.
  • Before and after screenshots show these changes.
  • I can see these changes in my local environment.
  • CodeQL alerts have been checked.

Things to change

  • Comments on the changes in the Pull Request: consider using backticks (`) to enclose the file path such as _projects/expunge-assist.md.

  • The correct slack for Srishti Gupta is https://hackforla.slack.com/team/U07FF4C4YFQ. Please update the code with this Slack URL. This also needs to be corrected in the original issue.

  • Try using http://localhost:4000 rather than 0.0.0.0:4000 for viewing the changes in your local environment.

  • The additional tabs in the provided screenshots are not needed. You can take the screenshot of the page in separate window or the specific visual change of the site.

Thank you for your contribution! Please feel free to ask if you have any questions. After making these changes re-request a review from me.

trimakichan
trimakichan previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@trimakichan trimakichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @katiejnete!

  • The PR is created with the correct branch.
  • The branch name accurately describes the work done and includes the issue number.
  • The issue is linked correctly.
  • The "What" and "Why" sections are clear and concise.
  • Before-and-after screenshots are provided to demonstrate the changes.
  • CodeQL alerts have been checked.

Thank you for your contribution! Keep up the great work!

@trimakichan trimakichan mentioned this pull request Nov 22, 2024
Open
@mugdhchauhan mugdhchauhan mentioned this pull request Nov 22, 2024
Open
rachelcorawood
rachelcorawood reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@rachelcorawood rachelcorawood left a comment •
edited by katiejnete
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things that went well:
-Your pull request is done in the correct branch
-The issue is linked correctly
-You clearly understand the issue
-The changes are visible in the browser and images are clear

Things to Update:

@mugdhchauhan
Copy link
Member

Review ETA: 23 Nov 2024 @ 10 AM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

mugdhchauhan
mugdhchauhan approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiejnete Thank you for making the changes and re-requesting a review from me. Looks good! I approve this PR.

@t-will-gillis
Copy link
Member

Great job @katiejnete with the PR and working with the reviewers to make the edits.
Kudos to @mugdhchauhan for a thorough review and esp. for noticing and correcting the Slack ID! This is easy to miss.

trimakichan
trimakichan approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@trimakichan trimakichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are all working.

@mugdhchauhan
Copy link
Member

Thank you @t-will-gillis

@codyjohnsontx
Copy link
Member

Review ETA: 24 Nov 2024 @ 12am (CST)
Availability: This week, Monday 9-11am, Tuesday 10-6, Friday 10-6

@t-will-gillis t-will-gillis reopened this Nov 25, 2024
codyjohnsontx
codyjohnsontx approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@codyjohnsontx codyjohnsontx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @katiejnete, thanks for the Pull Request!

Highlights:

The PR is targeting the correct branch.
The issue is properly linked.
Changes and their reasoning are clearly documented.
Availability and ETA are detailed in the issue.
Information for Srishti Gupta is added to the correct file.
Before/after screenshots effectively showcase the updates.
CodeQL alerts have been reviewed.
All links are working as expected.
Great work! 🎉

@codyjohnsontx codyjohnsontx mentioned this pull request Nov 25, 2024
Open
@belunatic belunatic self-requested a review November 25, 2024 17:22
@belunatic
Copy link
Member

Review ETA: 25 Nov 2024
Availability: 4-5 Monday/ Tuesday

belunatic
belunatic approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@belunatic belunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiejnete Amazing job, all look good and also thank you for taking care of the changes point out by others.

Keep up the good work!!

@belunatic belunatic mentioned this pull request Nov 25, 2024
Open
@mchait18 mchait18 self-requested a review November 25, 2024 19:46
@mchait18
Copy link
Member

Review ETA: 3:15 PM 11/25/2024
Availability: 9-3PM Monday-Thursday EST

@rachelcorawood rachelcorawood mentioned this pull request Nov 26, 2024
Open
mchait18
mchait18 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mchait18 mchait18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue, katiejnete!

You're doing these right:

  • The branch you made the change on is correct
  • The linked issue (original issue) number is included
  • The content required to add is accurate
  • The before / after screenshot is helpful to display the change

Great job!

@mchait18 mchait18 mentioned this pull request Nov 26, 2024
Open
@dvernon5 dvernon5 self-requested a review November 27, 2024 01:30
@dvernon5
Copy link
Member

Review ETA: 7:00pm PST 11/26/2024
Availability: 9AM - 6PM Tuesday & Wednesday of this week.

dvernon5
dvernon5 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@dvernon5 dvernon5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @katiejnete
Branch name looks good.
The code changes look perfect.
The issue is linked correctly
CodeQL alerts are good
The content added is correct
Before and After photos look stunning.

Everything looks fantastic. Great job

@daras-cu daras-cu merged commit 772b138 into hackforla:gh-pages Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchait18 mchait18 mchait18 approved these changes

@trimakichan trimakichan trimakichan approved these changes

@codyjohnsontx codyjohnsontx codyjohnsontx approved these changes

@dvernon5 dvernon5 dvernon5 approved these changes

@mugdhchauhan mugdhchauhan mugdhchauhan approved these changes

@belunatic belunatic belunatic approved these changes

@rachelcorawood rachelcorawood Awaiting requested review from rachelcorawood

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist Add Srishti Gupta
10 participants
@katiejnete @mugdhchauhan @trimakichan @t-will-gillis @codyjohnsontx @belunatic @mchait18 @dvernon5 @rachelcorawood @daras-cu