-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Expunge Assist project team with Rick Peng #7744
Updated Expunge Assist project team with Rick Peng #7744
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3:15 PM 11/20/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work @jakejjoyner
Proper into and from branches
Clear and simple what and why
Correctly added the team member Rick Peng’s info
Thanks for the PR!
Review ETA: 11/20/2024 Wed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job working on this issue, @jakejjoyner !
- The branch you made the change on is correct
- The linked issue number is included
- Availability and ETA are provided in the original issue
- The CodeQL Alerts are checked
- The change you made is accurate
- The before-and-after screenshots help display the changes
Things to improve:
- Name the branch with more specific details, for example,
expunge-assist-add-rick-peng-7701
- Provide your availability for the week instead of the day in the original issue
- Check the boxes of all the
Action Items
you completed in the original issue
You did an awesome job on your good first issue. Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakejjoyner Good job on your first good issue.
- The branch is correct and the issue is linked as well.
- The file changed is correct
- The before and after screenshots are great !
Keep it up !
Review ETA: 10 AM 11/22/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the naming convention of the issue is great
- before and after picture look good
- code added is clean and understandable
Suggestions:
- as one of out college explain, you will need to be more descriptive on the issue naming, ex:
update-expunge-project-profile-add-rick-peng
- in the What section try to include what file you changed
Amazing job!! Goodluck on your next one
Fixes #7701
What changes did you make?
Added Rick Peng to Expunge Assist team
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied