Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature-homepage-launch branch on Nov 19, 2024 #7738

Conversation

JessicaLucindaCheng
Copy link
Member

Fixes not applicable

What changes did you make?

  1. Updated feature-homepage-launch branch by merging gh-pages branch into it.
  2. Fixed links from homepage to specific cards on Program Areas page.
  3. In _data/internal/communities directory, changed operations.yml to ops.yml and update the name variable.

Why did you make the changes (we will use this info to test)?

  1. The reason is the feature-homepage-launch is out of date/sync with the changes in gh-pages branch.
  2. Due to refactoring done on the gh-pages branch, the linking on the homepage to the cards on the Program Areas page broke when updating the feature-homepage-launch branch with changes from gh-pages. Thus, I fixed it.
  3. Due to refactoring of how meeting times worked on the Communities of Practice page on the gh-pages branch, updating the feature-homepage-launch branch made the meeting times for Ops to not show the time. So, I updated the filename and name variable to match ops.yml in gh-pages branch to fix the problem.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes because just updating the feature-homepage-launch branch with changes from gh-pages branch

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b JessicaLucindaCheng-update-feature-homepage-launch-on-Nov-19-2024 feature-homepage-launch
git pull https://github.com/JessicaLucindaCheng/website.git update-feature-homepage-launch-on-Nov-19-2024

@JessicaLucindaCheng JessicaLucindaCheng merged commit 286ff48 into hackforla:feature-homepage-launch Nov 20, 2024
1 of 2 checks passed
@JessicaLucindaCheng JessicaLucindaCheng deleted the update-feature-homepage-launch-on-Nov-19-2024 branch November 20, 2024 02:14
@JessicaLucindaCheng JessicaLucindaCheng restored the update-feature-homepage-launch-on-Nov-19-2024 branch November 20, 2024 02:18
@JessicaLucindaCheng JessicaLucindaCheng deleted the update-feature-homepage-launch-on-Nov-19-2024 branch November 20, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant