-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website.md, remove Mario Anonini, #7459 #7718
Update website.md, remove Mario Anonini, #7459 #7718
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 11/15/2024 Friday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue, @codyjohnsontx !
You're doing these right:
- The branch you made the change on is correct
- The linked issue (original issue) number is included
- The content required to remove is accurate
- The CodeQL Alerts are checked
- The after screenshot is helpful to display the change
Changes you need to make:
- Address the questions from HackforLABot in the original issue (Availability and ETA)
- Fix the unnecessary changes and submit your PR again (It could be caused by the formatting tool in your IDE, such as prettier)
- Fix the before-and-after screenshots section (The images are not showing)
You can re-request me to review your PR once you make the changes. Feel free to reach out if you have any questions.
Availability for this week: Friday 4-6, Saturday 10-4, Sunday 10-4 My estimated ETA for completing this issue: 30 minutes to 1 hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job fixing the quotation marks in the file, @codyjohnsontx .
Things to improve:
- You only need to address your availability and ETA in the original issue (the linked issue you mentioned in your PR Update Project Profile: remove Mario Antonini from HackforLA.org Website #7459)
- Move the before-and-after screenshots to this section
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
- Check the changes requested by the reviewer once you make the changes
Other than these, everything looks good. Thank you for your contribution!
Review ETA: 10PM 11/16/24 |
Nice Work @codyjohnsontx ! Thanks for the PR! |
Hey @codyjohnsontx FYI- you do not need to assign yourself to your own PRs |
Fixes #7459
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Before
Visuals after changes are applied
After