Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Project Profile Adding Nilakshi Sahai #7714

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Update Project Profile Adding Nilakshi Sahai #7714

merged 3 commits into from
Nov 15, 2024

Conversation

belunatic
Copy link
Member

@belunatic belunatic commented Nov 10, 2024 •
edited by codyyjxn
Loading

Fixes #7648

What changes did you make?

  • I added Nilakshi Sahai to the current Project Team Section

Why did you make the changes (we will use this info to test)?

  • To update the Current Project Team Members

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

FireShot Capture 070 - LA TDM Calculator - Hack for LA - localhost

Visuals after changes are applied

FireShot Capture 071 - LA TDM Calculator - Hack for LA - localhost

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b belunatic-add-nilakshi-sahai-7648 gh-pages
git pull https://github.com/belunatic/website.git add-nilakshi-sahai-7648

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 10, 2024
@codyyjxn codyyjxn self-requested a review November 12, 2024 17:31
codyyjxn
codyyjxn requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@belunatic thank you for taking on this issue.

Suggestions

  • You need to respond to the bot in the comments below on the original issue.
  • You need to fix the conflict

@belunatic
Copy link
Member Author

updated image after resolving the conflict

FireShot Capture 072 - LA TDM Calculator - Hack for LA - localhost

codyyjxn
codyyjxn previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@belunatic Great job fixing the merge conflict! Thank you for your contribution keep it up !

@belunatic
Copy link
Member Author

Thank you @codyyjxn, I appreciate you!

@jphamtv
Copy link
Member

jphamtv commented Nov 15, 2024

Hi @belunatic - Please let team members self-assign PR reviews. Available reviewers will pick up PRs from the queue when they can work on them. This helps us maintain an efficient review process where available reviewers can schedule their workloads. Thanks!

@belunatic
Copy link
Member Author

@jphamtv I appreciate you! Have a great weekend!

ExperimentsInHonesty
ExperimentsInHonesty previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@ExperimentsInHonesty ExperimentsInHonesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Its ready for merge. I just made one change to her title. Changed it
from: Lead UX Design Lead
to: UX Design Lead

_projects/tdm-calculator.md Outdated Show resolved Hide resolved
@ExperimentsInHonesty ExperimentsInHonesty dismissed stale reviews from codyyjxn and themself via 2cbe05c November 15, 2024 19:20
@ExperimentsInHonesty
Copy link
Member

I am merging this to reduce confusion, since it already had two reviews.

@ExperimentsInHonesty ExperimentsInHonesty merged commit 132136d into hackforla:gh-pages Nov 15, 2024
3 checks passed
@belunatic belunatic deleted the add-nilakshi-sahai-7648 branch November 15, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyyjxn codyyjxn codyyjxn left review comments

@ExperimentsInHonesty ExperimentsInHonesty ExperimentsInHonesty left review comments

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator Add Nilakshi Sahai
4 participants
@belunatic @jphamtv @ExperimentsInHonesty @codyyjxn