Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: Guides Team Add Jesus Diaz #7665

Merged

Conversation

mamypoco
Copy link
Member

@mamypoco mamypoco commented Oct 29, 2024

Fixes #7584

What changes did you make?

- name: Jesus Diaz
  github-handle: JesseTheCleric
  role: Product Manager
  links:
    slack: https://hackforla.slack.com/team/U0725MRMMA9
    github: https://github.com/JesseTheCleric
  picture: https://avatars.githubusercontent.com/JesseTheCleric

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b mamypoco-guide-team-add-jesus-7584 gh-pages
git pull https://github.com/mamypoco/website.git guide-team-add-jesus-7584

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 29, 2024
@mamypoco mamypoco changed the title Added Jesus Dian as instructed Added Jesus Diaz as instructed #7584 Oct 29, 2024
@codyyjxn codyyjxn self-requested a review October 29, 2024 22:53
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamypoco Hey, thank you for taking on this issue.

Things that went well :

  • The branch name is correct
  • The changes are correct and visible with the before and after screenshots

Things that need to change :

  • Updated the pr title to align with the changes addressed similar to the original issue and remove the issue number.
  • Checked off the relevant completed tasks from the original issue.
  • Responded to the HackForLABot in the original issue.
  • The description should be more informative and the changes made section should be more on where the changes you made and which files you modified.

Thank you ! If you have any questions feel free to reach out.

@mamypoco mamypoco changed the title Added Jesus Diaz as instructed #7584 Update Project Profile: Guides Team Add Jesus Diaz Oct 29, 2024
@mamypoco
Copy link
Member Author

Thank you @codyyjxn, I checked the boxes for your review. This is my very first PR and you covered thoroughly!

@DrAcula27 DrAcula27 self-requested a review October 30, 2024 02:14
@DrAcula27
Copy link
Member

ETA: 1 November 2024
Availability: weekdays after 2pm

Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamypoco Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file -projects/guides-team.md was edited
  • No extra edits were made
  • Appearance of the website looks good (Chrome and Firefox)
  • Great job fixing your PR and re-requesting changes!
    Approved! 👍

@siyunfeng
Copy link
Member

Review ETA: 11/1/2024 Friday
Availability: 7-10 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job working on your good first issue, @mamypoco !

  • Availability and ETA are provided in the original issue
  • The linked issue is included in your PR
  • The change is accurate
  • Before-and-after screenshots are helpful to show the change you made

Improvement:

  • Provide specific detail to Why did you make the changes (we will use this info to test)?, such as to ensure the project leadership info is up to date / accurate

Thank you for your contribution!

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamypoco Great Job ! Keep it up !

@t-will-gillis t-will-gillis merged commit 28129b9 into hackforla:gh-pages Nov 4, 2024
37 checks passed
@mamypoco mamypoco deleted the guide-team-add-jesus-7584 branch November 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Guides Team Add Jesus Diaz
5 participants