-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Guides Team Add Jesus Diaz #7665
Update Project Profile: Guides Team Add Jesus Diaz #7665
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamypoco Hey, thank you for taking on this issue.
Things that went well :
- The branch name is correct
- The changes are correct and visible with the before and after screenshots
Things that need to change :
- Updated the pr title to align with the changes addressed similar to the original issue and remove the issue number.
- Checked off the relevant completed tasks from the original issue.
- Responded to the HackForLABot in the original issue.
- The description should be more informative and the
changes made
section should be more on where the changes you made and which files you modified.
Thank you ! If you have any questions feel free to reach out.
Thank you @codyyjxn, I checked the boxes for your review. This is my very first PR and you covered thoroughly! |
ETA: 1 November 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamypoco Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
-projects/guides-team.md
was edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
- Great job fixing your PR and re-requesting changes!
Approved! 👍
Review ETA: 11/1/2024 Friday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job working on your good first issue, @mamypoco !
- Availability and ETA are provided in the original issue
- The linked issue is included in your PR
- The change is accurate
- Before-and-after screenshots are helpful to show the change you made
Improvement:
- Provide specific detail to
Why did you make the changes (we will use this info to test)?
, such asto ensure the project leadership info is up to date / accurate
Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamypoco Great Job ! Keep it up !
Fixes #7584
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied