Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Allison Profile to 311 Data Page #7639

Merged

Conversation

trimakichan
Copy link
Member

Fixes #7542

What changes did you make?

  • Added Allison's profile to the 311-data.md file in the _projects folder.

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

update_project_profile_7542_before

Visuals after changes are applied

update_project_profile_7542_after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b trimakichan-update-project-profile-7542 gh-pages
git pull https://github.com/trimakichan/website.git update-project-profile-7542

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 26, 2024
@siyunfeng siyunfeng self-requested a review October 26, 2024 19:48
@siyunfeng
Copy link
Member

Review ETA: 10/26/2024 Sat
Availability: 6-10 PM Weekdays (EDT)

@terrencejihoonjung
Copy link
Member

Review ETA: 10/28/2024, 11:59pmPST
Availability: 5pm - 12am PST, Fri-Sun, 5pm - 9pm Mon

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job working on this issue, @trimakichan !

You provided your availability and ETA in the original issue, created a new branch to make the changes, and included the linked issue in your PR.

The answers to What changes did you make? and Why did you make the changes (we will use this info to test)? are clear so our fellow developers would have a better understanding of the issue and your schedule. The changes you made are accurate. I appreciate that you provided the before-and-after screenshots to show the changes you made.

Improvement:

  • Name the branch with more specific details, such as add-allison-jeon-profile-311-data-7542

Thank you for your contribution!

@codyyjxn codyyjxn self-requested a review October 26, 2024 22:44
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @trimakichan great job on this issue.

  • The branch name is good with the issue number
  • The issue is linked correctly
  • The changes are displayed correctly

One thing you need to do is on the original issue you need to tick one of the boxes that says : Verify the changes by viewing the following in your local environment and include before and after screenshots with your pull request:

That will complete this issue. Thank you for your contribution. Keep it up!

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trimakichan,

Looks great! Things you did well:

  • branching naming to and from
  • changes made and why they were made stated clearly
  • visual before and after provided
  • code changes are correct

Thank you for your contribution!

@trimakichan
Copy link
Member Author

Nice job working on this issue, @trimakichan !

You provided your availability and ETA in the original issue, created a new branch to make the changes, and included the linked issue in your PR.

The answers to What changes did you make? and Why did you make the changes (we will use this info to test)? are clear so our fellow developers would have a better understanding of the issue and your schedule. The changes you made are accurate. I appreciate that you provided the before-and-after screenshots to show the changes you made.

Improvement:

  • Name the branch with more specific details, such as add-allison-jeon-profile-311-data-7542

Thank you for your contribution!

Thank you so much for taking the time to check this issue, @siyunfeng! Your advice on naming the branch is helpful. Thanks!

@trimakichan
Copy link
Member Author

Hey @trimakichan great job on this issue.

  • The branch name is good with the issue number
  • The issue is linked correctly
  • The changes are displayed correctly

One thing you need to do is on the original issue you need to tick one of the boxes that says : Verify the changes by viewing the following in your local environment and include before and after screenshots with your pull request:

That will complete this issue. Thank you for your contribution. Keep it up!

Thank you for checking, @codyyjxn! I checked the box you mentioned. The next step is just to wait for my pull request to be merged, correct?

@siyunfeng
Copy link
Member

Hey @trimakichan great job on this issue.

  • The branch name is good with the issue number
  • The issue is linked correctly
  • The changes are displayed correctly

One thing you need to do is on the original issue you need to tick one of the boxes that says : Verify the changes by viewing the following in your local environment and include before and after screenshots with your pull request:
That will complete this issue. Thank you for your contribution. Keep it up!

Thank you for checking, @codyyjxn! I checked the box you mentioned. The next step is just to wait for my pull request to be merged, correct?

Yes, once this PR is merged, please fill out the info in ### 6 - PULL REQUESTS update and comment on your skills issue.

If this is your first good first issue, you can move on to your 2nd good first issue after completing the PULL REQUESTS update.

@trimakichan
Copy link
Member Author

Hi @trimakichan,

Looks great! Things you did well:

  • branching naming to and from
  • changes made and why they were made stated clearly
  • visual before and after provided
  • code changes are correct

Thank you for your contribution!

Thank you for checking! I appreciate you taking the time to do so, @terrencejihoonjung.

@trimakichan
Copy link
Member Author

Hey @trimakichan great job on this issue.

  • The branch name is good with the issue number
  • The issue is linked correctly
  • The changes are displayed correctly

One thing you need to do is on the original issue you need to tick one of the boxes that says : Verify the changes by viewing the following in your local environment and include before and after screenshots with your pull request:
That will complete this issue. Thank you for your contribution. Keep it up!

Thank you for checking, @codyyjxn! I checked the box you mentioned. The next step is just to wait for my pull request to be merged, correct?

Yes, once this PR is merged, please fill out the info in ### 6 - PULL REQUESTS update and comment on your skills issue.

If this is your first good first issue, you can move on to your 2nd good first issue after completing the PULL REQUESTS update.

Thank you for your quick reply and for describing the next step very clearly, @siyunfeng! I appreciate it.

@Thinking-Panda
Copy link
Member

@trimakichan Thank you for working on this issue.

@Thinking-Panda Thinking-Panda merged commit d6e4fd7 into hackforla:gh-pages Oct 29, 2024
7 checks passed
@trimakichan trimakichan deleted the update-project-profile-7542 branch October 30, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data Add Allison Jeon
5 participants