Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed James Higgs from tdm-calculator.md - #5394 #5423

Conversation

kezzaam
Copy link
Member

@kezzaam kezzaam commented Sep 3, 2023

Removed James Higgs from tdm-calculator.md

Fixes #5394

What changes did you make?

  • Removed James Higgs entry from leadership in _projects/tdm-calculator.md

Why did you make the changes (we will use this info to test)?

  • The information was out of date.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

![image]Screenshot 2023-09-03 at 12 20 18 PM

Visuals after changes are applied

![image]Screenshot 2023-09-03 at 12 21 40 PM

Removed James Higgs from tdm-calculator.md
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kezzaam-5394-update-project-profile-la-tdm-calculator-remove-james-higgs gh-pages
git pull https://github.com/kezzaam/website.git 5394-update-project-profile-la-tdm-calculator-remove-james-higgs

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 3, 2023
@homeroochoa47
Copy link
Member

Review ETA Monday 9/4 EOD
Availability Monday before 2

@ortegaa32 ortegaa32 self-requested a review September 3, 2023 22:48
@ortegaa32
Copy link
Member

Review ETA: 3 PM 9/5/23
Availability: 1-3 PM everyday

Copy link
Member

@homeroochoa47 homeroochoa47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up, @kezzaam! Everything looks great to me.

  • The branch was set up correctly.
  • The entry for James in the leadership variable was removed
  • Visual changes are as expected and appear the same as in the given images in my local environment
    Nice work!

@agutiernc agutiernc self-requested a review September 5, 2023 02:07
@agutiernc
Copy link
Member

Review ETA: 9/5/23
Availability: 5-8 PM Tuesday

Copy link
Member

@agutiernc agutiernc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the correct branch was used. Linked issue is added. Instructions were followed to remove the contributor from the file. I verified that changes were reflected on the website and no issues found while viewing in different viewports.

My only suggestion when naming a branch is to shorten it a bit. An example is shown in 2.7.b of the contributing doc.

Great job @kezzaam! Thanks for contributing!

@ortegaa32
Copy link
Member

  • Contains correct branch and is linked to correct issue
  • Visual changes accurately reflected in screenshots and don't break the website
  • Only modified relevant files

Great work @kezzaam!

@roslynwythe roslynwythe merged commit 61ebc44 into hackforla:gh-pages Sep 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator (remove James Higgs)
5 participants