-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed James Higgs from tdm-calculator.md - #5394 #5423
Removed James Higgs from tdm-calculator.md - #5394 #5423
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA Monday 9/4 EOD |
Review ETA: 3 PM 9/5/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up, @kezzaam! Everything looks great to me.
- The branch was set up correctly.
- The entry for James in the leadership variable was removed
- Visual changes are as expected and appear the same as in the given images in my local environment
Nice work!
Review ETA: 9/5/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the correct branch was used. Linked issue is added. Instructions were followed to remove the contributor from the file. I verified that changes were reflected on the website and no issues found while viewing in different viewports.
My only suggestion when naming a branch is to shorten it a bit. An example is shown in 2.7.b of the contributing doc.
Great job @kezzaam! Thanks for contributing!
Great work @kezzaam! |
Removed James Higgs from tdm-calculator.md
Fixes #5394
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
![image]
Visuals after changes are applied
![image]