-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commented out broken site links #5422
commented out broken site links #5422
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 9/5/23 |
I plan to review this by Sept 7th. |
Well done @JanineSooThow. Approving you pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JanineSooThow You have the correct from-to branches, you are linked to the original issue, you are explaining what you did and why, and you are providing before and after screenshots. Great job!
I have thing that I would like to request that was not specified on the original issue- you followed the issue correctly. This also does not affect the visuals on the website but instead involves the code itself: when commenting out the - name:
and url:
the code will appear cleaner and easier to read if the hashtags are aligned like so:
# - name: Site
# url: 'https://hellogov.squarespace.com'
# - name: Site
# url: 'https://jobs-for-hope.herokuapp.com/'
# - name: Site
# url: 'http://www.workfor.la/'
Again, you did the issue correctly! If you would make this change, I think the code will appear cleaner.
Thank you for working on this issue!
Hello @ortegaa32 thank you so much for reviewing my changes :D |
Hello @t-will-gillis thank you so much for the feedback! I really appreciate it! I made the changes on the branch '4923-comment-out-broken-site-links-for-workforla-hellogov-jobs-for-hope'. The changes definitely make the code look cleaner :D. I am not sure if I did the PR correctly , so please let me know if you can see my changes or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JanineSooThow Thanks so much for making the changes- Everything looks perfect!
* commented out broken site links * aligned hastags
Fixes #4923
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied