Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5167: Updated Project Profile #5417

Conversation

GRK1998
Copy link
Member

@GRK1998 GRK1998 commented Sep 2, 2023

Fixes #5167

What changes did you make?

-I have made changes to the title, description, leadership, GitHub Link, and Slack Link

Why did you make the changes (we will use this info to test)?

-The Brigade Organizers Playbook project page needs to be updated so that the project information is up to date.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-09-01 at 9 27 39 PM
Visuals after changes are applied Screenshot 2023-09-01 at 9 31 32 PM

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b GRK1998-Update-Project-Profile-Brigade-Organizers-Playbook-5167 gh-pages
git pull https://github.com/GRK1998/website.git Update-Project-Profile-Brigade-Organizers-Playbook-5167

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Sep 2, 2023
@ortegaa32 ortegaa32 self-requested a review September 3, 2023 22:49
@ortegaa32
Copy link
Member

Review ETA: 3 PM 9/5/23
Availability: 1-3 PM everyday

@ronaldpaek ronaldpaek self-requested a review September 4, 2023 13:23
@ronaldpaek
Copy link
Member

I plan to review this by Sept 7th.

@ortegaa32
Copy link
Member

  • Pull request has correct branch and is linked to the correct issue.
  • Changes don't appear to break the website and screenshots accurately reflect the changes.
  • Changes were made to correct file and source code looks clean

Good job @GRK1998. Approving pull request.

ortegaa32
ortegaa32 previously approved these changes Sep 5, 2023
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GRK1998 - Great job on this issue! Your branches are good, you have linked the issue, you are giving a short description of what you did and why, and you have provided before and after screenshots. Since there are changes, please provide before and after screenshots of the BOP project page as well.

Also- only in the description: you -correctly!- made the changes requested by the issue. Unfortunately, a separate PR 5454 fixes #5411 changed the same entry, so your PR has a merge conflict that needs to be addressed.

Therefore, for only the line description: please keep what is in the code currently and do not make the change shown on your issue. Here is a link from the CONTRIBUTING.md on what to do. If you would like help please ask.

Thank you for your work!

@t-will-gillis
Copy link
Member

Hi @GRK1998 - Could you please give an update on your progress on this PR? Again, if you have questions or need help please message myself or anyone else. Thank you

@t-will-gillis
Copy link
Member

@GRK1998 Please provide an update on this PR before Sunday or it will be closed. Thank you.

@GRK1998
Copy link
Member Author

GRK1998 commented Sep 30, 2023

I have resolved the issue please let me know if there are any changes to be made

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GRK1998 Thanks for making the changes and updating the description: Please update the title: as noted on #5167. Also, please provide visuals showing the 'before' and 'after' changes on the project page as well as on the Brigade Organizers Playbook page.

@GRK1998
Copy link
Member Author

GRK1998 commented Oct 1, 2023

Hi @t-will-gillis I have made the changes as requested.

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied Screenshot 2023-09-01 at 9 27 39 PM
Visuals after changes are applied Screenshot 2023-09-30 at 9 37 51 PM

Screenshots of Proposed Changes Of The Brigade Organizers Playbook page

Visuals before changes are applied Screenshot 2023-09-30 at 9 42 00 PM
Visuals after changes are applied Screenshot 2023-09-30 at 9 42 32 PM

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GRK1998 - Looks perfect, thank you

@t-will-gillis t-will-gillis merged commit a44ff7f into hackforla:gh-pages Oct 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Brigade Organizers Playbook
4 participants