-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5167: Updated Project Profile #5417
5167: Updated Project Profile #5417
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 9/5/23 |
I plan to review this by Sept 7th. |
Good job @GRK1998. Approving pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @GRK1998 - Great job on this issue! Your branches are good, you have linked the issue, you are giving a short description of what you did and why, and you have provided before and after screenshots. Since there are changes, please provide before and after screenshots of the BOP project page as well.
Also- only in the description:
you -correctly!- made the changes requested by the issue. Unfortunately, a separate PR 5454 fixes #5411 changed the same entry, so your PR has a merge conflict that needs to be addressed.
Therefore, for only the line description:
please keep what is in the code currently and do not make the change shown on your issue. Here is a link from the CONTRIBUTING.md on what to do. If you would like help please ask.
Thank you for your work!
Hi @GRK1998 - Could you please give an update on your progress on this PR? Again, if you have questions or need help please message myself or anyone else. Thank you |
@GRK1998 Please provide an update on this PR before Sunday or it will be closed. Thank you. |
I have resolved the issue please let me know if there are any changes to be made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GRK1998 Thanks for making the changes and updating the description:
Please update the title:
as noted on #5167. Also, please provide visuals showing the 'before' and 'after' changes on the project page as well as on the Brigade Organizers Playbook page.
Hi @t-will-gillis I have made the changes as requested. Screenshots of Proposed Changes Of The WebsiteScreenshots of Proposed Changes Of The Brigade Organizers Playbook page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GRK1998 - Looks perfect, thank you
Fixes #5167
What changes did you make?
-I have made changes to the title, description, leadership, GitHub Link, and Slack Link
Why did you make the changes (we will use this info to test)?
-The Brigade Organizers Playbook project page needs to be updated so that the project information is up to date.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied