Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audited the img tags ending with a slash #5099 #5416

Conversation

raviteja4117
Copy link
Member

@raviteja4117 raviteja4117 commented Sep 2, 2023

Fixes #5099

What changes did you make?

  • Removed ending slashes from HTML img tags in the file
  • Updated img Tag in theAudit spreadsheet

Why did you make the changes (we will use this info to test)?

  • Changes were made as requested in order to make the codebase consistent with the codebase

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b raviteja4117-update-Audit-for-img-tags-5099 gh-pages
git pull https://github.com/raviteja4117/website.git update-Audit-for-img-tags-5099

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML size: 0.5pt Can be done in 3 hours or less ready for dev lead Issues that tech leads or merge team members need to follow up on labels Sep 2, 2023
@allison-truhlar
Copy link
Member

ETA: Tuesday EOD
Availability: Tues 9-5pm ET

@allison-truhlar
Copy link
Member

Hi @raviteja4117! I realized after adding myself as a reviewer and reading the linked issue that I don't think this issue should have a pull request associated with it. The linked issue indicates that you should record the desired changes in the spreadsheet, but does not ask you to make the changes in the code yourself. Therefore, I think you should close this pull request. Completing the final action step (After all instances have been recorded in the sheet, add the ready for dev lead label to this issue and move it to the Questions/In Review column), which you did, I think should close out your required actions for this issue, unless the dev lead requests changes.

Otherwise - great job reviewing the _includes/press.html page for closing /> img tags to change. I see you recorded one instance in the audit spreadsheet - looking at the source code this looks correct, and you correctly recorded the "line of current code" and "line of desired code," as well as the link to the file on Github.

@LRenDO
Copy link
Member

LRenDO commented Sep 6, 2023

Hi @raviteja4117! This looks great as a PR. However, it is beyond the scope of the issue. Please see my review in #5099 for more information.

Good catch @allison-truhlar!

Closing this without merging since this is beyond the scope of the issue.

@LRenDO LRenDO closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit for img tags ending with a slash in file: _includes/press.html
3 participants