Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide nonfunctional engage links 5330 #5414

Merged

Conversation

erinzz
Copy link
Member

@erinzz erinzz commented Sep 1, 2023

Fixes #5330
Prev Pull Request #5346

What changes did you make?

  • Hid non-functional site link in Engage project card

Why did you make the changes (we will use this info to test)?

  • Currently the site link leads to a non-existent page. We want to hide the link until we have functional pages built for it.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screenshot 2023-09-01 at 3 28 24 PM

Visuals after changes are applied

Screenshot 2023-09-01 at 3 29 04 PM

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b erinzz-hide-nonfunctional-engage-links-5330 gh-pages
git pull https://github.com/erinzz/website.git hide-nonfunctional-engage-links-5330

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 1, 2023
Copy link
Member

@brianf4 brianf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @erinzz, everything looks perfect on my local machine. Well done!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @erinzz - Great job on this PR. Thanks for working with @brianf4 and @StephenTheDev1001 from the previous, closed PR. Your branches are correct, you have linked the original issue and the closed PR, your description is concise, and you have provided before and after visuals. Thanks for your work to address the broken link on the Engage project!

@t-will-gillis t-will-gillis merged commit 6f629d2 into hackforla:gh-pages Sep 3, 2023
10 checks passed
@erinzz erinzz deleted the hide-nonfunctional-engage-links-5330 branch September 8, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment out broken Site link on Engage project
3 participants