Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor secondRepoId for clarity #5412

Merged

Conversation

davidwiese
Copy link
Member

Fixes #5231

What changes did you make?

  • Refactored secondRepoId in civic-tech-index.md, project.html, current-projects.js, and project.js
  • Confirmed with Docker that everything remained the same as on the live website

Why did you make the changes (we will use this info to test)?

  • So the name is more descriptive and clearer that it will contain additional repository ID numbers for a project

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Code refactor resulted in no visual changes to the website

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b davidwiese-refactor-secondrepoid-5231 gh-pages
git pull https://github.com/davidwiese/website.git refactor-secondrepoid-5231

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ size: 1pt Can be done in 4-6 hours labels Sep 1, 2023
@t-will-gillis
Copy link
Member

available and eta: 9/3

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidwiese Excellent work again. Your bases are covered: branches are good, issue is linked, descriptions are concise, and it appears you have made the changes described in the original issue. On Docker it appears that the "Projects" pages and "Civic Tech Index", esp. the filters and the "Languages: ", function as in the current website.
Thanks for working on this issue!

@t-will-gillis t-will-gillis merged commit 4d67758 into hackforla:gh-pages Sep 4, 2023
10 checks passed
@davidwiese davidwiese deleted the refactor-secondrepoid-5231 branch September 4, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor secondRepoId for clarity
2 participants