-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTML to resolve linter error in about-card-executive-letter #5405
Refactor HTML to resolve linter error in about-card-executive-letter #5405
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 9/1/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @euthanizedtortoise! It appears as though there is no issue linked to this pull request. In the first line: Fixes #replace_this_text_with_the_issue_number, could you please add the issue number that this pull request is addressing. Also, could you please be more descriptive in your pull request and if there are no visual changes to the website you could just delete everything after the "Screenshots of Proposed Changes Of The Website" and note that there are no visual changes. After making those changes, please request another review and I'd be glad to approve your changes. Thanks!
ok thanks for letting me know i’ll get to it
Sent from Gmail Mobile
…On Fri, Sep 1, 2023 at 3:22 PM Arturo Ortega ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey @euthanizedtortoise <https://github.com/euthanizedtortoise>! It
appears as though there is no issue linked to this pull request. In the
first line: Fixes #replace_this_text_with_the_issue_number, could you
please add the issue number that this pull request is addressing. Also,
could you please be more descriptive in your pull request and if there are
no visual changes to the website you could just delete everything after the
"Screenshots of Proposed Changes Of The Website" and note that there are no
visual changes. After making those changes, please request another review
and I'd be glad to approve your changes. Thanks!
—
Reply to this email directly, view it on GitHub
<#5405 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZA4JH5YTI2YMAUE663YF3XYJN2XANCNFSM6AAAAAA4HEWJTI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Just fixed it feel free to check when you have time. :) |
Good job on your first pull request @euthanizedtortoise! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @euthanizedtortoise - Great job on your first issue and working with @ortegaa32. The branches are correct, the original issue is linked, the description explains what was done and why, and the code changes are clean. Looks good- thanks!
Fixes #5317
What changes did you make?
div
tag.Why did you make the changes (we will use this info to test)?