Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTML to resolve linter error in about-card-executive-letter #5405

Conversation

connortessaro
Copy link
Member

@connortessaro connortessaro commented Sep 1, 2023

Fixes #5317

What changes did you make?

  • Replaced single quotes with double quotes in the class attribute of the div tag.

Why did you make the changes (we will use this info to test)?

  • To resolve the linter error stating "Value of attribute [class] must be in double quotes."
  • To ensure consistency and adherence to coding standards within the project.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b euthanizedtortoise-refactor-html-linter-error-5317 gh-pages
git pull https://github.com/euthanizedtortoise/website.git refactor-html-linter-error-5317

@ortegaa32 ortegaa32 self-requested a review September 1, 2023 21:53
@ortegaa32
Copy link
Member

Review ETA: 3 PM 9/1/23
Availability: 1-3 PM everyday

Copy link
Member

@ortegaa32 ortegaa32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @euthanizedtortoise! It appears as though there is no issue linked to this pull request. In the first line: Fixes #replace_this_text_with_the_issue_number, could you please add the issue number that this pull request is addressing. Also, could you please be more descriptive in your pull request and if there are no visual changes to the website you could just delete everything after the "Screenshots of Proposed Changes Of The Website" and note that there are no visual changes. After making those changes, please request another review and I'd be glad to approve your changes. Thanks!

@connortessaro
Copy link
Member Author

connortessaro commented Sep 1, 2023 via email

@connortessaro
Copy link
Member Author

Just fixed it feel free to check when you have time. :)

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 2, 2023
@ortegaa32
Copy link
Member

  • Pull request contains correct branch
  • Pull request links to correct issue.
  • Changes don't appear to break the website
  • Changes made to the right file and source code looks good.

Good job on your first pull request @euthanizedtortoise!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @euthanizedtortoise - Great job on your first issue and working with @ortegaa32. The branches are correct, the original issue is linked, the description explains what was done and why, and the code changes are clean. Looks good- thanks!

@t-will-gillis t-will-gillis merged commit 8e0bcfb into hackforla:gh-pages Sep 4, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _includes/about-page/about-card-executive-letter.html
3 participants