-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project profile5320 #5400
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 3 PM 9/1/23 |
Hey @ndmoc. It appears as though there is no issue linked to this pull request. In the first line: Fixes #replace_this_text_with_the_issue_number, could you please add the issue number that this pull request is addressing. Thanks! |
Its been completed, thank you! |
Availability: In the evening & on weekends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ndmoc! Great work on your pull request!
- The new branch is properly going into the correct branch gh-pages. ✅
- Original issue was properly linked and referenced. ✅
- The specified person is added ✅
- However, a file that is not specified in the issue was deleted
assets/images/join-us/donation-graphic.svg
. Please restore it and commit your changes! - Another small note I would make about the pull request itself - it would be great if you could remove the empty bullet points from the first 2 sections of the pull request description.
After all the changes, please request the review again, I'll be glad to approve it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Pull request contains correct branches
- Pull request links correct issue
Hey @ndmoc. Looking good so far! Just a couple of notes: - I noticed in your screenshots that there were a few people added to the website besides Josiah Odosu. If I remember correctly, MJ Shelton was removed sometime this week. Also, when I try to test the changes on my computer I encounter an error when merging. Maybe you forgot to pull before making changes?
- I noticed you deleted a file that was not specified in this specific issue. Could you restore it and commit please.
After addressing these issues, please request another review and I'll be happy to approve!
Hi Meru, Thank you for the feedback. Yeah, I was working on another first issue that asked me to remove the file. I can link it here while its pending review. #5398 Please advise. Thank you, |
Hey @ndmoc – going through PRs and noticed that you took up this issue while your first issue was awaiting to be merged. Just a reminder, per the message from the github-actions bot from your self-assignment to the issue, developers may not take up another issue while waiting for their initial issue to be closed. Part of this is to ensure that developers take into account the feedback from their first PR code review and learn about our process and standards for merging for their subsequent issues. If you would like to contribute while waiting for an issue to get merged, you can help by completing other developers' pull requests! 😄 |
Fixes #5320
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied