Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project profile5320 #5400

Closed
wants to merge 2 commits into from

Conversation

ndmoc
Copy link
Member

@ndmoc ndmoc commented Aug 31, 2023

Fixes #5320

What changes did you make?

  • Updated Project Profile by adding Josiah Odosu

Why did you make the changes (we will use this info to test)?

  • Task was to add Josiah Odosu's information under Bonnie's section

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@ndmoc ndmoc added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: member profile labels Aug 31, 2023
@ndmoc ndmoc self-assigned this Aug 31, 2023
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ndmoc-Update-Project-Profile5320 gh-pages
git pull https://github.com/ndmoc/website.git Update-Project-Profile5320

@ortegaa32 ortegaa32 self-requested a review August 31, 2023 21:19
@ortegaa32
Copy link
Member

Review ETA: 3 PM 9/1/23
Availability: 1-3 PM everyday

@ortegaa32
Copy link
Member

Hey @ndmoc. It appears as though there is no issue linked to this pull request. In the first line: Fixes #replace_this_text_with_the_issue_number, could you please add the issue number that this pull request is addressing. Thanks!

@ndmoc
Copy link
Member Author

ndmoc commented Aug 31, 2023

Hey @ndmoc. It appears as though there is no issue linked to this pull request. In the first line: Fixes #replace_this_text_with_the_issue_number, could you please add the issue number that this pull request is addressing. Thanks!

Its been completed, thank you!

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: member profile labels Aug 31, 2023
@pearlescence-m
Copy link
Member

Availability: In the evening & on weekends
Review ETA: EOD 09/01

Copy link
Member

@pearlescence-m pearlescence-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ndmoc! Great work on your pull request!

  • The new branch is properly going into the correct branch gh-pages. ✅
  • Original issue was properly linked and referenced. ✅
  • The specified person is added ✅
  • However, a file that is not specified in the issue was deleted assets/images/join-us/donation-graphic.svg. Please restore it and commit your changes!
  • Another small note I would make about the pull request itself - it would be great if you could remove the empty bullet points from the first 2 sections of the pull request description.

After all the changes, please request the review again, I'll be glad to approve it!

Copy link
Member

@ortegaa32 ortegaa32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pull request contains correct branches
  • Pull request links correct issue
    Hey @ndmoc. Looking good so far! Just a couple of notes:
  • I noticed in your screenshots that there were a few people added to the website besides Josiah Odosu. If I remember correctly, MJ Shelton was removed sometime this week. Also, when I try to test the changes on my computer I encounter an error when merging. Maybe you forgot to pull before making changes?
  • I noticed you deleted a file that was not specified in this specific issue. Could you restore it and commit please.

After addressing these issues, please request another review and I'll be happy to approve!

@ndmoc
Copy link
Member Author

ndmoc commented Sep 1, 2023

Hi @ndmoc! Great work on your pull request!

  • The new branch is properly going into the correct branch gh-pages. ✅
  • Original issue was properly linked and referenced. ✅
  • The specified person is added ✅
  • However, a file that is not specified in the issue was deleted assets/images/join-us/donation-graphic.svg. Please restore it and commit your changes!
  • Another small note I would make about the pull request itself - it would be great if you could remove the empty bullet points from the first 2 sections of the pull request description.

After all the changes, please request the review again, I'll be glad to approve it!

Hi Meru,

Thank you for the feedback.

Yeah, I was working on another first issue that asked me to remove the file. I can link it here while its pending review. #5398

Please advise.

Thank you,
Andy

@adrianang
Copy link
Member

Hey @ndmoc – going through PRs and noticed that you took up this issue while your first issue was awaiting to be merged.

Just a reminder, per the message from the github-actions bot from your self-assignment to the issue, developers may not take up another issue while waiting for their initial issue to be closed. Part of this is to ensure that developers take into account the feedback from their first PR code review and learn about our process and standards for merging for their subsequent issues.

If you would like to contribute while waiting for an issue to get merged, you can help by completing other developers' pull requests! 😄

@t-will-gillis
Copy link
Member

Hello @ndmoc You already have one open issue #4466. Per the Pre-work Checklist, we ask devs to focus on completing one issue at a time. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: HackforLA.org Website (Josiah Odosu)
5 participants