Refactor HTML: _includes/about-page/about-card-platform.html - Giving closing span tag

[kristinstockley]

Fixes #5369

What changes did you make?

• added </span> after Giving
• Prettier extension may have removed some white spaces throughout the file automatically, but I did not personally make those changes

Why did you make the changes (we will use this info to test)?

• Repaired tag, missing </span> after Giving

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kristinstockley-refactor-html-giving-5369 gh-pages
git pull https://github.com/kristinstockley/hackforla-website.git refactor-html-giving-5369

[antho-zng]

About page with refactored HTML looks the same as current page across desktop, mobile, tablet views (previewed using Chrome DevTools on Docker-hosted page). Removed whitespace has not changed the formatting or spacing on the text. Great job! :)

[adrianang]

Hi @kristinstockley — the branching is set up correctly, the corresponding issue is linked, the What/Why of the PR was descriptive, the requested change of adding the closing span tag to the element on line 45 was made, and it did not seem to affect the About page visually or functionally.

Just a note for future PRs — you may want to turn off your Prettier linter while working with the Website codebase. This is because although your Prettier was what caused the whitespace removal and not you actively removing it, those removals will still register as a change in the codebase as your version of the about-card-platform.html file is compared to the one on the gh-pages branch. For this issue, it's not so much of a problem, but for other, more complex issues down the road, it can cause merge conflicts when working with other developers. I'll approve and merge this issue this time as the whitespace removals are cosmetic, but just something to keep in mind for next time.

Thank you for completing this issue! 🙌🏼