Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out test site for engage project #5339

Merged

Conversation

brianf4
Copy link
Member

@brianf4 brianf4 commented Aug 29, 2023

Fixes #4924

What changes did you make?

  • Updated by commenting out name for "test site"
  • Updated by commenting out URL for "test site"

Why did you make the changes (we will use this info to test)?

  • To temporarily hide this link from the website's visitors until we have the correct and functioning link in place.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before-screenshot
Visuals after changes are applied after-screenshot

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b brianf4-comment-out-test-site-link-4924 gh-pages
git pull https://github.com/brianf4/website.git comment-out-test-site-link-4924

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 29, 2023
@Thinking-Panda Thinking-Panda self-requested a review August 29, 2023 22:02
@Thinking-Panda
Copy link
Member

Availability- Weekdays 10AM- 3PM
ETA- 8/30

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianf4 , Nice work with the issue. Merge branches are correct, code changes are as mentioned in the issue and website works perfect on my local machine. Well done. Thanks!

Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work All file changes and visual changes look correct to me.

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brianf4 - great job on your first issue! Branches are correct, issue is linked, description explains what was done and why, screenshots are included, and code is clean. Changes are reflected in Docker with nothing unexpected.
Thanks for working on this!

@t-will-gillis t-will-gillis merged commit f74b071 into hackforla:gh-pages Sep 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment out broken Test Site link for Engage project
4 participants