img Tag Refactor - removed ending slash for meetup.svg - #5184

[pearlescence-m]

Fixes #5184

What changes did you make?

• Removed ending slash for img tag of meetup.svg

Why did you make the changes (we will use this info to test)?

• Needed a consistent codebase with how we use img HTML tags

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

No visual changes.

Visuals after changes are applied

No visual changes.

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b pearlescence-m-img-Tag-Refactor-meetup-5184 gh-pages
git pull https://github.com/pearlescence-m/website.git img-Tag-Refactor-meetup-5184

[MattChau01]

Availability: In the evening & most of the day on weekends
ETA: Expected to finish review by EOD Friday

[LRenDO]

Hi @yujioshiro, @ronaldpaek, and @Jfong1218! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. Thanks!

[Jfong1218]

PR Review:
Availability: weekdays afternoon starting 8/24
ETA: EOD 8/26

[MattChau01]

• The new branch is properly going into the correct branch gh-pages. ✅
• Original issue img Tag Refactor: _includes/events-page/left-col-content.html - meetup.svg #5184 was properly linked and referenced. ✅
• The specified instance of an <img> tag on line 2 was properly adjusted to match the consistency of code. ✅

Great work! I think the only room for adjustment would be to edit your comment and remove the Screenshots section since there were no visual images attached. Other than that, good on my side!

[ronaldpaek]

Great job, all changes to the file look correct to me. :)

[Jfong1218]

Great job!
I can confirm that the ending slash for img tag for meetup.svg has been deleted, and none of the other lines of code were affected.
The website behaved the same before and after the change.

Issue # was properly linked
The merge is commit into hackforla: gh-pages
The code is clean

[adrianang]

Hi @pearlescence-m — the branching is set up correctly, the corresponding issue is linked, the requested change of removing the ending slash in line 2 was made exactly as asked, and it doesn't seem to affect anything on my local environment (as expected).

The What and Why of your PR are clearly written, but I would agree with @MattChau01's suggestion of deleting the Screenshot section, or at least removing the <summary> and <details> tags from those sections (and saying there aren't visual changes, as you did above).

Also, I notice that you had made another pull request (#5299) while this one was in the process of being reviewed; per the Github Actions bot message for this issue posted upon your self-assignment, developers may not assign themselves to more than one open issue at a time (the PR of the issue must also be closed, not only submitted).

Thanks for taking up this issue! 🙌🏼