Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the html img tag refactor in about-card-partners.html #5261

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

raviteja4117
Copy link
Member

Fixes #5198

What changes did you make?

  • Removed ending slash in the img HTML tag in file _includes/about-page/about-card-partners.html

Why did you make the changes (we will use this info to test)?

  • I refactored img HTML Tag to Maintain Consistency Across the codebase.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b raviteja4117-img-tag-refactor-5198 gh-pages
git pull https://github.com/raviteja4117/website.git img-tag-refactor-5198

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 20, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @raviteja4117 on this issue. You setup the branches correctly, made the correct code change, and prepared a well-formed and descriptive pull request. The code checks out fine in the browser (although note that the image is only displayed in mobile views).

@christinaor
Copy link
Member

Confirming the PR was written correctly and descriptively like Roslyn said, and the closing "/" has been removed for consistency as mentioned. Good job @raviteja4117 !

@christinaor christinaor merged commit e90ff82 into hackforla:gh-pages Aug 22, 2023
10 checks passed
@ronaldpaek ronaldpaek removed their request for review September 4, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: _includes/about-page/about-card-partners.html - partners.svg
3 participants