Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img tag refactor issue 5042, works #5251

Merged

Conversation

SeyiAkinwale
Copy link
Member

Fixes #5042

What changes did you make?

-removed slash in img self closing tag

Why did you make the changes (we will use this info to test)?

-to make the use of the img tag consistent with others on site

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-no visual changes to website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b SeyiAkinwale-img-tag-refactor5042 gh-pages
git pull https://github.com/SeyiAkinwale/website.git img-tag-refactor5042

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers 2 weeks inactive An issue that has not been updated by an assignee for two weeks Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 18, 2023
@SeyiAkinwale SeyiAkinwale removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Aug 18, 2023
@njackman-2344
Copy link
Member

The html slash was removed in code. Great Job @SeyiAkinwale!

@mademarc
Copy link
Member

Review ETA: 8/24/2023
Availability: 7:20PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SeyiAkinwale Well done removing the slash on the html img tag on the line 18 for this issue.

Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to this project. You have successfully submitted your first pull request. You have followed the best practices of linking the pull request to the relevant issue, naming the branch appropriately, and providing clear and concise descriptions of your changes and their rationale. I have tested your code in the browser and it works as expected.

@SeyiAkinwale SeyiAkinwale self-assigned this Aug 25, 2023
@StephenTheDev1001
Copy link
Contributor

@njackman-2344
https://github.com/hackforla/website/wiki/How-to-Review-Pull-Requests#step-6-approve-the-pull-request
image

@drakenguyen4000 drakenguyen4000 merged commit a477eb8 into hackforla:gh-pages Aug 27, 2023
17 checks passed
@ronaldpaek ronaldpaek removed their request for review August 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: wins page - wins-card-big-quote
6 participants