-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
img tag refactor issue 5042, works #5251
img tag refactor issue 5042, works #5251
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
The html slash was removed in code. Great Job @SeyiAkinwale! |
Review ETA: 8/24/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SeyiAkinwale Well done removing the slash on the html img tag on the line 18 for this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to this project. You have successfully submitted your first pull request. You have followed the best practices of linking the pull request to the relevant issue, naming the branch appropriately, and providing clear and concise descriptions of your changes and their rationale. I have tested your code in the browser and it works as expected.
Fixes #5042
What changes did you make?
-removed slash in img self closing tag
Why did you make the changes (we will use this info to test)?
-to make the use of the img tag consistent with others on site
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
-no visual changes to website