Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor img Tag in About Page #5241

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

ortegaa32
Copy link
Member

@ortegaa32 ortegaa32 commented Aug 17, 2023

Fixes #5197

What changes did you make?

  • Removed ending slash in img HTML tag

Why did you make the changes (we will use this info to test)?

  • To make codebase consistent

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Slightly changed img tag. No visual changes to website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ortegaa32-img-tag-refactor-5197 gh-pages
git pull https://github.com/ortegaa32/website.git img-tag-refactor-5197

@github-actions github-actions bot added Feature: Refactor HTML size: 1pt Can be done in 4-6 hours role: dev leads Tasks for technical leads Issue Making: Level 2 Make issue(s) from an ER or Epic Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level labels Aug 17, 2023
@ortegaa32 ortegaa32 linked an issue Aug 17, 2023 that may be closed by this pull request
5 tasks
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ size: 0.25pt Can be done in 0.5 to 1.5 hours and removed size: 1pt Can be done in 4-6 hours role: dev leads Tasks for technical leads Issue Making: Level 2 Make issue(s) from an ER or Epic Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level labels Aug 17, 2023
@DorianDeptuch DorianDeptuch self-requested a review August 17, 2023 23:55
@DorianDeptuch
Copy link
Member

Availability: Afternoons
ETA: 8/17 EOD

Copy link
Member

@DorianDeptuch DorianDeptuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ortegaa32,

The ending slash was removed correctly from the img tag and your documentation was done correctly as well. I tested this in my local environment and everything runs as it should. Everything looks good to me, great job!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ortegaa32 — the branching is set up correctly, the corresponding issue is linked, and the requested change of removing the ending slash on the image tag on line 9 has been made. Per the issue instructions, only the ending slash on this line was removed — thank you for keeping that in mind! When testing this branch on my local environment, the sponsor instances and the rest of the About page seem to not be affected (as expected).

I would say the Why of your PR could be a bit more descriptive (what are we being consistent to?), but I think this is just something to keep in mind for future PRs.

Thanks for taking up this issue! 🙌🏼

@adrianang adrianang merged commit 0b5dc0e into hackforla:gh-pages Aug 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: _includes/about-page/about-card-partners.html - partner.name
3 participants