-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor img Tag in About Page #5241
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: Afternoons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ortegaa32,
The ending slash was removed correctly from the img tag and your documentation was done correctly as well. I tested this in my local environment and everything runs as it should. Everything looks good to me, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ortegaa32 — the branching is set up correctly, the corresponding issue is linked, and the requested change of removing the ending slash on the image tag on line 9 has been made. Per the issue instructions, only the ending slash on this line was removed — thank you for keeping that in mind! When testing this branch on my local environment, the sponsor instances and the rest of the About page seem to not be affected (as expected).
I would say the Why of your PR could be a bit more descriptive (what are we being consistent to?), but I think this is just something to keep in mind for future PRs.
Thanks for taking up this issue! 🙌🏼
Fixes #5197
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Slightly changed img tag. No visual changes to website