Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor home unite tools 4808 #5144

Merged

Conversation

Jmmcclo2023
Copy link
Member

Fixes #4808

What changes did you make?

  • Located the tools entry within the _projects/home-unite-us.md file
  • Reformatted the tools data and removed the unwanted entry
  • Confirmed that the data is rendered correctly with Docker

Why did you make the changes (we will use this info to test)?

  • Requested to do so by the instructions of the issue (This was labeled as a good first issue)
  • The new format is required for the filter menu on the projects-check to work properly

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Issue#4808_BeforeChanges

Visuals after changes are applied

Issue#4808_2
Issue#4808_1

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Jmmcclo2023-refactor-home-unite-tools-4808 gh-pages
git pull https://github.com/Jmmcclo2023/website.git refactor-home-unite-tools-4808

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Aug 5, 2023
@one2code one2code self-requested a review August 5, 2023 03:02
Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jmmcclo2023 — your branching is set up correctly, the corresponding issue is linked, and the requested change has been made (refactor the tools for Home Unite Us into a list, and remove Docker from this list). In testing your branch on my local machine through Docker, the Tools list no longer shows Docker on the project page and card views for Home Unite Us, and no other part of the website seems to be affected. Your PR was also quite well-written and documents the what, why, and screenshots of the change nicely; great work, I appreciate the effort!

Thank you for taking up this issue! 🙌🏼

Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on resolving the issue by updating the formatting on the tools field, and congratulations on your first pull request.

@adrianang adrianang merged commit 9b68452 into hackforla:gh-pages Aug 6, 2023
10 checks passed
@Jmmcclo2023 Jmmcclo2023 deleted the refactor-home-unite-tools-4808 branch August 7, 2023 02:42
@Jmmcclo2023 Jmmcclo2023 restored the refactor-home-unite-tools-4808 branch August 7, 2023 02:42
@Jmmcclo2023 Jmmcclo2023 deleted the refactor-home-unite-tools-4808 branch August 7, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Tools data for home-unite-us.md
3 participants