-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor home unite tools 4808 #5144
Refactor home unite tools 4808 #5144
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jmmcclo2023 — your branching is set up correctly, the corresponding issue is linked, and the requested change has been made (refactor the tools for Home Unite Us into a list, and remove Docker from this list). In testing your branch on my local machine through Docker, the Tools list no longer shows Docker on the project page and card views for Home Unite Us, and no other part of the website seems to be affected. Your PR was also quite well-written and documents the what, why, and screenshots of the change nicely; great work, I appreciate the effort!
Thank you for taking up this issue! 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on resolving the issue by updating the formatting on the tools field, and congratulations on your first pull request.
Fixes #4808
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied