Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img Tag Refactor: Program Areas Page #5142

Conversation

ivan20203
Copy link
Member

Fixes #5139

What changes did you make?

  • change end of img tag of program_areas[1].image from with a slash(" />" ) to without a slash (">").

Why did you make the changes (we will use this info to test)?

  • So the codebase is consistent with how we use img HTML tags.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-08-04 at 13 32 25 Screenshot 2023-08-04 at 13 29 36 Screenshot 2023-08-04 at 13 50 45
Visuals after changes are applied Screenshot 2023-08-04 at 13 31 57 Screenshot 2023-08-04 at 13 31 31 Screenshot 2023-08-04 at 13 51 04

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ivan20203-img-tag-refactor-program-areas-page-5139 gh-pages
git pull https://github.com/ivan20203/website.git img-tag-refactor-program-areas-page-5139

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 4, 2023
@steven-positive-tran
Copy link
Member

Avail: 8/4
ETA: 8/4 EOD

Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches look good, works on my machine and changes in code seems in line with the issue that needs to be addressed.

Good job and thanks for taking up this issue.

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ivan20203 — your branching is set up correctly and succinctly summarizes the change made, the corresponding issue is linked to, and the requested change of removing the ending slash on the img tag on line 24 of the Program Areas page was made exactly as requested.

In testing your branch on my local environment through Docker, the rendered images for each of the cards don't appear visually or functionally impacted, as expected.

Thanks for taking up this issue! 🙌🏼

@adrianang adrianang merged commit 15b2990 into hackforla:gh-pages Aug 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Program Areas Page - program_areas[1].image
3 participants