Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastapi migration GitHub Actions and Alembic migration #820

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

paulespinosa
Copy link
Member

Related #789

What changes did you make?

  • Updated the GitHub action that runs the frontend and api tests
  • Updated the alembic migration script to capture the current database schema

Rationale behind the changes?

  • This is part of the FastAPI migration. The Github action needed to be updated to run the new API test code.

Testing done for these changes

  • Ran pytest and ran docker containers

This commits removes the previous migration script. A new initial migration
script is added that creates all the tables and inserts data into the role
table.

The alembic migration tests have been removed until the tests can be configured
to accommodate this type of test.
This autogenerated migration script had a hard coded default value for a
datetime that does not work in a SQLite database. This commit uses the
SQLAlchemy function to generate the default value based on the type of database
being used.
The example.com is RFC 2606 reserved second level domain intended for
documentation and testing.
Document local development test user accounts.
@johnwroge johnwroge closed this Oct 18, 2024
@johnwroge johnwroge reopened this Oct 18, 2024
Copy link
Member

@johnwroge johnwroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Paul.

@paulespinosa paulespinosa merged commit 4bccfda into main Oct 18, 2024
2 of 4 checks passed
@paulespinosa paulespinosa deleted the fastapi-conversion branch October 18, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants