-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Client Page Implementation #63
base: develop
Are you sure you want to change the base?
Conversation
Hi Melika, great job on all of the work on this page!! I'm having an issue where when I try to create a new client, I get:
and when I try to add a child to the client, the following message appears:
Possible Fixes?Did you happen to run into either of these issues? I tried adding the client without logging in and then with logging in but encountered the same problem.
Are you able to share what inputs you used to make the form work correctly, and I can try to replicate on my end. Actionable Item- I think adding some placeholders within the input tags with the desired input format such as "### ### ####" for phone number, might mitigate some of these input issues (if this is what is causing the problem). Smaller Notes
All in all, really great work on this!! :) |
Developer: Melika Dabiri
Closes #48
Pull Request Summary
Implemented the Add New Client page:
Modifications
addNewClient page, api folder, components folder
Testing Considerations
I did multiple tests adding clients with different numbers of household members, child and adult, and authorized members. Some points left to consider are:
Lastly, the addNewClient page.tsx file has currently grown pretty lengthy. I would appreciate any feedback on whether the way I went about doing things could be simplified! I can also separate the helper functions into a separate file as some of them can also be repurposed as general utility functions for using the API.
Pull Request Checklist
Screenshots/Screencast
Clicking Add Client saves the data to the database and logs the result on the console.