Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 4 - Elaina Lyons #247

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

elainalyons
Copy link

Milestone: 4

Developer: Elaina Lyons

Pull Request Summary

Completed milestone 4 is being submitted for review. POST endpoints were added to complete the blog and portfolio functionality with comments, and email.js was used to complete the Contact Me page.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit message follows our guidelines
  • The milestone number is specified
  • The developer name is specified
  • The summary is completed

Reviewer Checklist - PULL REQUEST REVIEWER ONLY

IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized pull request reviewers. If you are the individual template contributor, do not fill out the rest of the fields or check the boxes.

NOTE: Milestones can only be completed when all boxes are checked.

  • The code is fully reviewed
  • Meaningful feedback is given
  • Comment that you have reviewed the code
  • This box is checked

Copy link

gitguardian bot commented Jan 31, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- MongoDB Credentials 4b70eac bootcamp-milestone-2/.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@elainalyons
Copy link
Author

Milestone4Email

Forgot to include proof of the email working through the contact me page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant