Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3A/3B/4 - Matthew Bosio #229

Closed
wants to merge 13 commits into from

Conversation

mtbosio
Copy link

@mtbosio mtbosio commented Dec 23, 2023

Developer: Matthew Bosio

Closes #168

Pull Request Summary

Finished Milestone 4

  • POST API endpoints for comments.
  • Contact me page sends emails to yourself
  • Deployed website!
    Also refactored some of my code, cleaned up folders, added comment functionality to portfolio.

Special Instructions (optional)

Pull Request Checklist

  • [x ] Code is neat, readable, and works
  • [x ] Comments are appropriate
  • [ x] The commit messages follows our guidelines
  • [ x] The developer name is specified
  • [ x] The summary is completed
  • [ x] Ask for a review in communication channels

Screenshots/Screencast

Screenshot 2023-12-23 at 12 44 41 PM

Website URL: https://bootcamp-project-2023-matthew-bosio-2437qae5w-mtbosios-projects.vercel.app/portfolio/65500c3e282dfa20a3103250

Copy link

gitguardian bot commented Dec 23, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- MongoDB Credentials c142baa bootcamp-milestone-2/src/app/.env View secret
- MongoDB Credentials 845fdab Milestone3/src/app/helpers/db.ts View secret
- MongoDB Credentials 845fdab Milestone3/src/app/.env View secret
- MongoDB Credentials c142baa bootcamp-milestone-2/src/app/helpers/db.ts View secret
- MongoDB Credentials 845fdab Milestone3/src/app/helpers/db.ts View secret
- MongoDB Credentials c142baa bootcamp-milestone-2/src/app/helpers/db.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@javalosr2004
Copy link
Collaborator

Hi, can you please you update your Vercel authentication for the website. It seems to be private at the moment. Thank you!

@mtbosio
Copy link
Author

mtbosio commented Jan 3, 2024

Hi, can you please you update your Vercel authentication for the website. It seems to be private at the moment. Thank you!

Hi I updated the authentication. Thanks

@javalosr2004
Copy link
Collaborator

Hi Matthew! Nice job on completing the milestones, I want to say your website feels very responsive given the loading page and comments loading immediately upon submission, two areas of improvement however could be to not have the comment form display while loading the website and to tidy up some of the css. Congratulations on finishing bootcamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestone 4
2 participants