Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3B/4 #173

Closed
wants to merge 30 commits into from
Closed

Milestone 3B/4 #173

wants to merge 30 commits into from

Conversation

devinhadley
Copy link

@devinhadley devinhadley commented Dec 17, 2023

Developer: Devin Hadley

Closes #134 #168

Pull Request Summary

Finish milestone 3b/4

Special Instructions (optional)

Pull Request Checklist

  • [X ] Code is neat, readable, and works
  • [ X] Comments are appropriate
  • [ X] The commit messages follows our guidelines
  • [X ] The developer name is specified
  • [X ] The summary is completed
  • [ X] Ask for a review in communication channels
    image
    image

Copy link

gitguardian bot commented Dec 17, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- MongoDB Credentials b8936e7 bootcamp-milestone-4/.env View secret
- MongoDB Credentials ad20ac2 bootcamp-milestone-3A/.env View secret
- MongoDB Credentials 5ed13db bootcamp-milestone-3B/.env View secret
- MongoDB Credentials 336ff58 bootcamp-milestone-4/.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@devinhadley devinhadley changed the title Milestone 3B Milestone 3B/4 Dec 21, 2023
@javalosr2004
Copy link
Collaborator

Nice work Devin! Your website was one of the first I saw completed and it is amazing the level of detail you put into it! From the loading screen, to the css animations, your code is well formatted and easily readable, alongside this you implented module css correctly, congratulations on finishing bootcamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIlestone 3B
2 participants