Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone 2 - James Torres #123

Closed
wants to merge 16 commits into from
Closed

Milestone 2 - James Torres #123

wants to merge 16 commits into from

Conversation

jam-kt
Copy link

@jam-kt jam-kt commented Nov 11, 2023

Developer: James Torres

Closes #66

Pull Request Summary

Converted Milestone 1 from CSS/HTML to React using tsx.

Special Instructions (optional)

Pull Request Checklist

  • [ x ] Code is neat, readable, and works
  • [ x ] Comments are appropriate
  • [ x ] The commit messages follows our guidelines
  • [ x ] The developer name is specified
  • [ x ] The summary is completed
  • [ x ] Ask for a review in communication channels

Screenshots/Screencast

jam-kt added 16 commits October 22, 2023 19:06
@jam-kt
copied starter pack files
c18bf4b
@jam-kt
feat: add blog.ts and update blog.html
8b9a6ea
@jam-kt
feat: add basic CSS styling for blog cards. Update blog.ts
0777e51
@jam-kt
feat: added blogCat.html and blogFoods.html. Update blog.ts
1524853
@jam-kt
feat: update blog.ts and blogCat.html to add contnt. Move cat.jpg to …
d55a18e 
…blogs folder
@jam-kt
feat: add blogFoods.html, add katsuCurry.jpg into blogs folder
0b2a3f5
@jam-kt
fix: fixed gitignore
600e138
@jam-kt
feat: set up milestone 2 Next.js
5f1e3ba
@jam-kt
fix: add src to project. Reformat structure
af7f086
@jam-kt
feat: converted navbar and index (now called page) into react
893f34e
@jam-kt
feat: convert footer to react
4b7943e
@jam-kt
feat: updated footer message
28a2db4
@jam-kt
feat: convert resume into react
70328ed
@jam-kt
feat: convert contact page to react
97f4938
@jam-kt
feat: added images folder, fixed links
ca3dfe6
@jam-kt
added blog previews
4b8c90e
@connorpobrien connorpobrien self-requested a review November 12, 2023 22:20
connorpobrien
connorpobrien reviewed Nov 12, 2023
View reviewed changes
Copy link

@connorpobrien connorpobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ragdassi ragdassi self-assigned this Nov 13, 2023
@ragdassi
Copy link

ragdassi commented Nov 13, 2023 •
edited
Loading

Great job! One thing to note- in your portfolio page, you can reduce redundant code by making a PortfolioSection component where you pass in the unique project name, description, and images as props. Keep up the good work!

@ragdassi ragdassi removed their assignment Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorpobrien connorpobrien connorpobrien left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Milestone 2 - Converting To React
3 participants
@jam-kt @ragdassi @connorpobrien