Milestone 2 - Asarel Castellanos #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaksana
reviewed
Nov 29, 2023
| @@ -0,0 +1,16 @@ | |||
| import Link from "next/link"; | |||
|
|
|||
| export default function BlogPreview({title, content, date, img, slug}: BlogPreviewProps) { | |||
There was a problem hiding this comment.
Instead of having a separate types file, it would be better to have the prop type in the same file imo. This is so whoever is trying to use the component can see the component and expected props all in one file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Asarel Castellanos
Closes #66
Pull Request Summary
Completed Milestone 2:
Pull Request Checklist
Screenshots/Screencast
Home Page
Blogs Page
Blog Page
Portfolio Page
Resume Page
Contact Page