fix(RELEASE-1338): new build for old catalog index #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theflockers
force-pushed
the
release-1338
branch
3 times, most recently
from
8c7ce2f to
97a2fef
Compare
this PR makes the iib-add-fbc-fragment-to-index-image task to call a new IIB build when the resumed catalog index is older than the upstream one to ensure the catalog integrity. Signed-off-by: Leandro Mendes <[email protected]>
|
This is a new required parameter, so it is a breaking change to the task creating the InternalRequest, no? |
luckily it is not a breaking change because this parameter is already sent by the managed pipeline task. I suspect (did not look tbh) this parameter was dropped some time ago but it was not changed in the managed one. |
johnbieren
reviewed
Dec 18, 2024
internal-services/catalog/iib-add-fbc-fragment-to-index-image-task.yaml
Outdated
Show resolved
Hide resolved
theflockers
force-pushed
the
release-1338
branch
from
97a2fef to
8da01e5
Compare
johnbieren
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR make the iib-add-fbc-fragment to require a new IIB build when the resumed catalog is older than the upstream one to ensure the catalog integrity.
Signed-off-by: Leandro Mendes [email protected]