feat: add sign-image pipeline #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pipeline yaml is a copy of the pipeline we currently use: hacbs-signing-pipeline The goal here is to enable retry in the request-signature task, see here: https://issues.redhat.com/browse/RELEASE-1194 For that, I needed to update the task reference. But that broke the task because the current version of the task does not have the signature_data result. In order to test this, I am deploying this modified pipeline under a different name. Once this is tested, we may actually switch to using this going forward - we can evaluate this afterwards. Signed-off-by: Martin Malina <[email protected]>
mmalina
force-pushed
the
signing-pipeline
branch
from
da4acfd to
e6791a2
Compare
scoheb
approved these changes
Oct 1, 2024
|
We need a migration ticket for this like https://issues.redhat.com/browse/RELEASE-1040 |
I created https://issues.redhat.com/browse/RELEASE-1206 and also https://issues.redhat.com/browse/RELEASE-1207 to actually start using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pipeline yaml is a copy of the pipeline we currently use: hacbs-signing-pipeline
The goal here is to enable retry in the request-signature task, see here:
https://issues.redhat.com/browse/RELEASE-1194
For that, I needed to update the task reference. But that broke the task because the current version of the task does not have the signature_data result.
In order to test this, I am deploying this modified pipeline under a different name.
Once this is tested, we may actually switch to using this going forward - we can evaluate this afterwards.