Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RELEASE-1024): update checkton version and allow it to fail #182

Merged
merged 1 commit into from
Sep 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
yamllint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Run yamllint
uses: frenck/action-yamllint@v1
with:
Expand All @@ -20,13 +20,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: checkout files
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install tkn cli
uses: jerop/[email protected]
with:
version: v${TKN_CLI_VERSION}
- name: Get changed files
uses: tj-actions/changed-files@v35
uses: tj-actions/changed-files@v41
id: changed-files
with:
files: |
Expand All @@ -42,7 +42,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
Expand All @@ -60,14 +60,7 @@ jobs:
fetch-depth: 0
- name: Run Checkton
id: checkton
uses: chmeliik/checkton@v0.1.2 # Migrating to the konflux-ci org
uses: chmeliik/checkton@v0.2.2 # Migrating to the konflux-ci org
with:
# Let there be green. GitHub's code scanning will do the reporting.
fail-on-findings: false
fail-on-findings: true
find-copies-harder: true
- name: Upload SARIF File
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: ${{ steps.checkton.outputs.sarif }}
# Avoid clashing with ShellCheck
category: checkton